Skip to content

[lldb][debugserver] Save and restore the SVE/SME register state #134184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 3, 2025
Merged

[lldb][debugserver] Save and restore the SVE/SME register state #134184

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7cc45f1
[lldb][debugserver] Save and restore the SVE/SME register state
jasonmolenda Apr 3, 2025
432a68d
reformat
jasonmolenda Apr 3, 2025
63e08b6
reformater
jasonmolenda Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 40 additions & 7 deletions lldb/tools/debugserver/source/MacOSX/arm64/DNBArchImplARM64.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2952,8 +2952,15 @@ kern_return_t DNBArchMachARM64::SetRegisterState(int set) {
return err;

switch (set) {
case e_regSetALL:
return SetGPRState() | SetVFPState() | SetEXCState() | SetDBGState(false);
case e_regSetALL: {
kern_return_t ret =
SetGPRState() | SetVFPState() | SetEXCState() | SetDBGState(false);
if (CPUHasSME()) {
ret |= SetSVEState();
ret |= SetSMEState();
}
return ret;
}
case e_regSetGPR:
return SetGPRState();
case e_regSetVFP:
Expand Down Expand Up @@ -3119,9 +3126,20 @@ uint32_t DNBArchMachARM64::SaveRegisterState() {
"error: GPR regs failed to read: %u ",
kret);
} else if ((kret = GetVFPState(force)) != KERN_SUCCESS) {
DNBLogThreadedIf(LOG_THREAD, "DNBArchMachARM64::SaveRegisterState () "
"error: %s regs failed to read: %u",
DNBLogThreadedIf(LOG_THREAD,
"DNBArchMachARM64::SaveRegisterState () "
"error: %s regs failed to read: %u",
"VFP", kret);
} else if (CPUHasSME() && (kret = SetSVEState() != KERN_SUCCESS)) {
DNBLogThreadedIf(LOG_THREAD,
"DNBArchMachARM64::SaveRegisterState () "
"error: %s regs failed to read: %u",
"SVE", kret);
} else if (CPUHasSME() && (kret = SetSMEState() != KERN_SUCCESS)) {
DNBLogThreadedIf(LOG_THREAD,
"DNBArchMachARM64::SaveRegisterState () "
"error: %s regs failed to read: %u",
"SME", kret);
} else {
const uint32_t save_id = GetNextRegisterStateSaveID();
m_saved_register_states[save_id] = m_state.context;
Expand All @@ -3144,11 +3162,26 @@ bool DNBArchMachARM64::RestoreRegisterState(uint32_t save_id) {
save_id, kret);
success = false;
} else if ((kret = SetVFPState()) != KERN_SUCCESS) {
DNBLogThreadedIf(LOG_THREAD, "DNBArchMachARM64::RestoreRegisterState "
"(save_id = %u) error: %s regs failed to "
"write: %u",
DNBLogThreadedIf(LOG_THREAD,
"DNBArchMachARM64::RestoreRegisterState "
"(save_id = %u) error: %s regs failed to "
"write: %u",
save_id, "VFP", kret);
success = false;
} else if ((kret = SetSVEState()) != KERN_SUCCESS) {
DNBLogThreadedIf(LOG_THREAD,
"DNBArchMachARM64::RestoreRegisterState "
"(save_id = %u) error: %s regs failed to "
"write: %u",
save_id, "SVE", kret);
success = false;
} else if ((kret = SetSMEState()) != KERN_SUCCESS) {
DNBLogThreadedIf(LOG_THREAD,
"DNBArchMachARM64::RestoreRegisterState "
"(save_id = %u) error: %s regs failed to "
"write: %u",
save_id, "SME", kret);
success = false;
}
m_saved_register_states.erase(pos);
return success;
Expand Down