-
Notifications
You must be signed in to change notification settings - Fork 15.5k
[RISCV] Add symbol parsing support for the Xqcibi branch immediate instructions #134233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| # RUN: llvm-mc -triple riscv32 -mattr=+experimental-xqcibi %s -show-encoding \ | ||
| # RUN: | FileCheck -check-prefix=INSTR -check-prefix=FIXUP %s | ||
| # RUN: llvm-mc -filetype=obj -triple riscv32 -mattr=+experimental-xqcibi %s -o %t.o | ||
| # RUN: llvm-readobj -r %t.o | FileCheck -check-prefix=RELOC %s | ||
|
|
||
| # Check prefixes: | ||
| # RELOC - Check the relocation in the object. | ||
| # FIXUP - Check the fixup on the instruction. | ||
| # INSTR - Check the instruction is handled properly by the ASMPrinter. | ||
|
|
||
| .text | ||
|
|
||
| # Check that branch to an undefined symbol is handled | ||
| # FIXME: This should be relaxed to an inverse branch and jump | ||
| qc.bnei x6, 10, foo | ||
| # RELOC: R_RISCV_BRANCH foo 0x0 | ||
| # INSTR: qc.bnei t1, 10, foo | ||
| # FIXUP: fixup A - offset: 0, value: foo, kind: fixup_riscv_branch | ||
|
|
||
| # FIXME: This should be relaxed to an inverse branch and jump | ||
| qc.e.bgeui x8, 12, foo | ||
| # RELOC: R_RISCV_CUSTOM193 foo 0x0 | ||
| # INSTR: qc.e.bgeui s0, 12, foo | ||
| # FIXUP: fixup A - offset: 0, value: foo, kind: fixup_riscv_qc_e_branch | ||
|
|
||
| # Check that a label in a different section is handled similar to an undefined symbol | ||
| # FIXME: This should be relaxed to an inverse branch and jump | ||
| qc.e.bltui x4, 9, .bar | ||
| # RELOC: R_RISCV_CUSTOM193 .bar 0x0 | ||
| # INSTR: qc.e.bltui tp, 9, .bar | ||
| # FIXUP: fixup A - offset: 0, value: .bar, kind: fixup_riscv_qc_e_branch | ||
|
|
||
| # Check that branches to a defined symbol are handled correctly | ||
| qc.e.beqi x7, 8, .L1 | ||
| # INSTR: qc.e.beqi t2, 8, .L1 | ||
| # FIXUP: fixup A - offset: 0, value: .L1, kind: fixup_riscv_qc_e_branch | ||
|
|
||
| .L1: | ||
| ret | ||
|
|
||
| .section .t2 | ||
|
|
||
| .bar: | ||
| ret | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.