Skip to content

[mlir][SPIRV] IfOpConversion: Compute result types earlier #134380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025
Merged

[mlir][SPIRV] IfOpConversion: Compute result types earlier #134380

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions mlir/lib/Conversion/SCFToSPIRV/SCFToSPIRV.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,18 @@ struct IfOpConversion : SCFToSPIRVPattern<scf::IfOp> {
// subsequently converges.
auto loc = ifOp.getLoc();

// Compute return types.
SmallVector<Type, 8> returnTypes;
for (auto result : ifOp.getResults()) {
auto convertedType = typeConverter.convertType(result.getType());
if (!convertedType)
return rewriter.notifyMatchFailure(
loc,
llvm::formatv("failed to convert type '{0}'", result.getType()));

returnTypes.push_back(convertedType);
}

// Create `spirv.selection` operation, selection header block and merge
// block.
auto selectionOp =
Expand Down Expand Up @@ -261,16 +273,6 @@ struct IfOpConversion : SCFToSPIRVPattern<scf::IfOp> {
thenBlock, ArrayRef<Value>(),
elseBlock, ArrayRef<Value>());

SmallVector<Type, 8> returnTypes;
for (auto result : ifOp.getResults()) {
auto convertedType = typeConverter.convertType(result.getType());
if (!convertedType)
return rewriter.notifyMatchFailure(
loc,
llvm::formatv("failed to convert type '{0}'", result.getType()));

returnTypes.push_back(convertedType);
}
replaceSCFOutputValue(ifOp, selectionOp, rewriter, scfToSPIRVContext,
returnTypes);
return success();
Expand Down