Skip to content

[SPIR-V] Add spv.gep support for ptrcast legal #134388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025
Merged

[SPIR-V] Add spv.gep support for ptrcast legal #134388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions llvm/lib/Target/SPIRV/SPIRVLegalizePointerCast.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,12 @@ class SPIRVLegalizePointerCast : public FunctionPass {
DeadInstructions.push_back(Intrin);
continue;
}

if (Intrin->getIntrinsicID() == Intrinsic::spv_gep) {
GR->replaceAllUsesWith(CastedOperand, OriginalOperand,
/* DeleteOld= */ false);
continue;
}
}

llvm_unreachable("Unsupported ptrcast user. Please fix.");
Expand Down
47 changes: 47 additions & 0 deletions llvm/test/CodeGen/SPIRV/pointers/getelementptr-downcast-struct.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
; RUN: llc -verify-machineinstrs -O0 -mtriple=spirv-unknown-vulkan-compute %s -o - | FileCheck %s --match-full-lines
; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-vulkan %s -o - -filetype=obj | spirv-val %}

; CHECK-DAG: %[[#uint:]] = OpTypeInt 32 0
; CHECK-DAG: %[[#uint64:]] = OpTypeInt 64 0
; CHECK-DAG: %[[#uint_pp:]] = OpTypePointer Private %[[#uint]]
; CHECK-DAG: %[[#uint_0:]] = OpConstant %[[#uint]] 0
; CHECK-DAG: %[[#uint_1:]] = OpConstant %[[#uint]] 1
; CHECK-DAG: %[[#uint_10:]] = OpConstant %[[#uint]] 10
; CHECK-DAG: %[[#t_array:]] = OpTypeArray %[[#uint]] %[[#uint_10]]
; CHECK-DAG: %[[#t_s1:]] = OpTypeStruct %[[#t_array]]
; CHECK-DAG: %[[#t_s2_s_a_s:]] = OpTypeStruct %[[#uint]] %[[#uint]]
; CHECK-DAG: %[[#t_s2_s_a:]] = OpTypeArray %[[#t_s2_s_a_s]] %[[#uint_10]]
; CHECK-DAG: %[[#t_s2_s:]] = OpTypeStruct %[[#t_s2_s_a]]
; CHECK-DAG: %[[#t_s2:]] = OpTypeStruct %[[#t_s2_s]] %[[#uint]]
; CHECK-DAG: %[[#null_s1:]] = OpConstantNull %[[#t_s1]]
; CHECK-DAG: %[[#null_s2:]] = OpConstantNull %[[#t_s2]]
; CHECK-DAG: %[[#ptr_s1:]] = OpTypePointer Private %[[#t_s1]]
; CHECK-DAG: %[[#ptr_s2:]] = OpTypePointer Private %[[#t_s2]]

%S1 = type { [10 x i32] }
%S2 = type { { [10 x { i32, i32 } ] }, i32 }

; CHECK-DAG: %[[#global1:]] = OpVariable %[[#ptr_s1]] Private %[[#null_s1]]
@global1 = internal addrspace(10) global %S1 zeroinitializer
; CHECK-DAG: %[[#global2:]] = OpVariable %[[#ptr_s2]] Private %[[#null_s2]]
@global2 = internal addrspace(10) global %S2 zeroinitializer

define spir_func noundef i32 @foo(i64 noundef %index) local_unnamed_addr {
; CHECK: %[[#index:]] = OpFunctionParameter %[[#uint64]]
entry:
; CHECK: %[[#ptr:]] = OpInBoundsAccessChain %[[#uint_pp]] %[[#global1]] %[[#uint_0]] %[[#index]]
%ptr = getelementptr inbounds %S1, ptr addrspace(10) @global1, i64 0, i32 0, i64 %index
; CHECK: %[[#val:]] = OpLoad %[[#uint]] %[[#ptr]] Aligned 4
%val = load i32, ptr addrspace(10) %ptr
ret i32 %val
}

define spir_func noundef i32 @bar(i64 noundef %index) local_unnamed_addr {
; CHECK: %[[#index:]] = OpFunctionParameter %[[#uint64]]
entry:
; CHECK: %[[#ptr:]] = OpInBoundsAccessChain %[[#uint_pp]] %[[#global2]] %[[#uint_0]] %[[#uint_0]] %[[#index]] %[[#uint_1]]
%ptr = getelementptr inbounds %S2, ptr addrspace(10) @global2, i64 0, i32 0, i32 0, i64 %index, i32 1
; CHECK: %[[#val:]] = OpLoad %[[#uint]] %[[#ptr]] Aligned 4
%val = load i32, ptr addrspace(10) %ptr
ret i32 %val
}