Skip to content

[Clang][Sema]:Fix musttail attribute on a function with not_tail_called attribute has no warning/error #134465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 14, 2025
Merged

[Clang][Sema]:Fix musttail attribute on a function with not_tail_called attribute has no warning/error #134465

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
596679a
[llvm][Stmt]:git clang format
MillePlateaux Apr 4, 2025
8999e0f
Add error report
MillePlateaux Apr 8, 2025
bf4921f
Error report
MillePlateaux Apr 8, 2025
28acee4
Report error when a musttail call is made to a function marked with t…
MillePlateaux Apr 10, 2025
2b285ec
#GH134465 Modified version
MillePlateaux Apr 11, 2025
abedbaf
Modified version
MillePlateaux Apr 11, 2025
2f18960
Modified version-3
MillePlateaux Apr 11, 2025
79789ab
Add note version
MillePlateaux Apr 14, 2025
670da2c
not 'here' version
MillePlateaux Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions clang/include/clang/Basic/DiagnosticSemaKinds.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3134,6 +3134,9 @@ def warn_function_attribute_ignored_in_stmt : Warning<
"use '%0' on statements">,
InGroup<IgnoredAttributes>;

def err_musttail_conflicts_with_not_tail_called : Error<
Copy link
Collaborator

@AaronBallman AaronBallman Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we reuse err_musttail_mismatch instead?

"%0 musttail conflicts with not tail called"
>;
def err_musttail_needs_trivial_args : Error<
"tail call requires that the return value, all parameters, and any "
"temporaries created by the expression are trivially destructible">;
Expand Down
8 changes: 8 additions & 0 deletions clang/lib/Sema/SemaStmt.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,6 +717,14 @@ bool Sema::checkMustTailAttr(const Stmt *St, const Attr &MTA) {
return false;
}

if (const FunctionDecl *CalleeDecl = CE->getDirectCallee()) {
if (CalleeDecl->hasAttr<NotTailCalledAttr>()) {
Diag(St->getBeginLoc(), diag::err_musttail_conflicts_with_not_tail_called)
<< &MTA;
return false;
}
}
Copy link
Collaborator

@AaronBallman AaronBallman Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (const FunctionDecl *CalleeDecl = CE->getDirectCallee()) {
if (CalleeDecl->hasAttr<NotTailCalledAttr>()) {
Diag(St->getBeginLoc(), diag::err_musttail_conflicts_with_not_tail_called)
<< &MTA;
return false;
}
}
if (const FunctionDecl *CalleeDecl = CE->getDirectCallee();
CalleeDecl && CalleeDecl->hasAttr<NotTailCalledAttr>()) {
Diag(St->getBeginLoc(), diag::err_musttail_conflicts_with_not_tail_called)
<< &MTA;
return false;
}


if (const auto *EWC = dyn_cast<ExprWithCleanups>(E)) {
if (EWC->cleanupsHaveSideEffects()) {
Diag(St->getBeginLoc(), diag::err_musttail_needs_trivial_args) << &MTA;
Expand Down