Skip to content

[lldb] Make RegisterContextThreadMemory thread safe #134469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
felipepiovezan merged 1 commit into from
Apr 5, 2025
Merged

[lldb] Make RegisterContextThreadMemory thread safe #134469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lldb/source/Plugins/Process/Utility/RegisterContextThreadMemory.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ RegisterContextThreadMemory::RegisterContextThreadMemory(
RegisterContextThreadMemory::~RegisterContextThreadMemory() = default;

void RegisterContextThreadMemory::UpdateRegisterContext() {
std::lock_guard<std::mutex> lock(m_update_register_ctx_lock);

ThreadSP thread_sp(m_thread_wp.lock());
if (thread_sp) {
ProcessSP process_sp(thread_sp->GetProcess());
Expand Down
2 changes: 2 additions & 0 deletions lldb/source/Plugins/Process/Utility/RegisterContextThreadMemory.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,8 @@ class RegisterContextThreadMemory : public lldb_private::RegisterContext {
RegisterContextThreadMemory(const RegisterContextThreadMemory &) = delete;
const RegisterContextThreadMemory &
operator=(const RegisterContextThreadMemory &) = delete;

std::mutex m_update_register_ctx_lock;
};

} // namespace lldb_private
Expand Down
Loading