[flang-rt] Fixed warnings and miscompilations in CUDA build. #134470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* DescribeIEEESignaledExceptions() is unused on the device - warning. * StopStatementText() could return while marked noreturn - warning. * Including cuda/std/complex only in the device compilation may cause nvcc to try to register variables in `cuda` namespace, while they are not defined in the host compilation - error. I decided to include cuda/std/complex always under RT_USE_LIBCUDACXX.
clementval
approved these changes
Apr 5, 2025
Contributor
clementval
left a comment
clementval
left a comment
There was a problem hiding this comment.
LGTM! Thanks for fixing the warnings
klausler
approved these changes
Apr 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
may cause nvcc to try to register variables in
cudanamespace,while they are not defined in the host compilation - error.
I decided to include cuda/std/complex always under RT_USE_LIBCUDACXX.