gn build: Add check-builtins target. #134482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1 [skip ci]
Created using spr 1.3.6-beta.1
aeubanks
approved these changes
Apr 7, 2025
Contributor
aeubanks
left a comment
aeubanks
left a comment
There was a problem hiding this comment.
wow this is very messy, feels like there should be a better way to do this on the CMake side
Contributor
Author
Yeah, or maybe even in the tests themselves, maybe they should be using weak symbols for the builtins and return unsupported if the symbol is undefined at runtime. |
Created using spr 1.3.6-beta.1 [skip ci]
pcc
changed the base branch from
users/pcc/spr/main.gn-build-add-check-builtins-target
to
main
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Apr 7, 2025
Tested on aarch64 Linux and x86_64 Linux. Reviewers: aeubanks, nico Reviewed By: aeubanks Pull Request: llvm/llvm-project#134482
Contributor
|
This breaks |
Contributor
Author
|
Isn't that a new file? I would expect it to try to add it to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on aarch64 Linux and x86_64 Linux.