[AMDGPU] Skip debug machine instructions in AMDGPU SIWholeQuadMode pass. #134518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-debuginfo @llvm/pr-subscribers-backend-amdgpu Author: None (kpyzhov) ChangesFull diff: https://github.com/llvm/llvm-project/pull/134518.diff 1 Files Affected:
diff --git a/llvm/lib/Target/AMDGPU/SIWholeQuadMode.cpp b/llvm/lib/Target/AMDGPU/SIWholeQuadMode.cpp
index 57ae7d63218dd..8ae134a7b8091 100644
--- a/llvm/lib/Target/AMDGPU/SIWholeQuadMode.cpp
+++ b/llvm/lib/Target/AMDGPU/SIWholeQuadMode.cpp
@@ -1300,6 +1300,12 @@ void SIWholeQuadMode::processBlock(MachineBasicBlock &MBB, BlockInfo &BI,
for (unsigned Idx = 0;; ++Idx) {
MachineBasicBlock::iterator Next = II;
+
+ if (II != IE && II->isDebugInstr()) {
+ II = ++Next;
+ continue;
+ }
+
char Needs = StateExact | StateWQM; // Strict mode is disabled by default.
char OutNeeds = 0;
|
kpyzhov
changed the title
arsenm
reviewed
Apr 7, 2025
| for (unsigned Idx = 0;; ++Idx) { | ||
| MachineBasicBlock::iterator Next = II; | ||
|
|
||
| if (II != IE && II->isDebugInstr()) { |
Contributor
There was a problem hiding this comment.
Why not all meta instructions? Also testcase?
arsenm
reviewed
Apr 10, 2025
| bb.0: | ||
| successors: %bb.1(0x40000000), %bb.2(0x40000000); %bb.1(50.00%), %bb.2(50.00%) | ||
| liveins: $sgpr0, $sgpr1, $sgpr2, $sgpr3, $sgpr4, $sgpr5, $sgpr6, $sgpr7, $sgpr8, $sgpr9, $sgpr10, $sgpr11, $sgpr12, $sgpr13, $sgpr14, $sgpr15, $sgpr16, $sgpr17, $sgpr18, $sgpr19, $vgpr8, $vgpr9, $vgpr12, $vgpr51, $vgpr52, $vgpr53, $vgpr54, $vgpr55, $vgpr56, $vgpr57, $vgpr58, $vgpr59, $vgpr60, $vgpr61 | ||
| %126:vgpr_32 = COPY $vgpr60, debug-instr-number 754 |
Contributor
There was a problem hiding this comment.
-run-pass=none to compact the register numbers
Comment on lines
+7
to
+25
| declare void @test() #0 | ||
|
|
||
| !0 = !DILocalVariable(name: "rayPayload", arg: 1, scope: !661, file: !106, line: 232, type: !304) | ||
| !36 = !DIBasicType(name: "unsigned int", size: 32, align: 32, encoding: DW_ATE_unsigned) | ||
| !106 = !DIFile(filename: "./RaytracingShaderHelper.hlsli", directory: "") | ||
| !153 = !DIDerivedType(tag: DW_TAG_typedef, name: "UINT", file: !106, line: 20, baseType: !154) | ||
| !154 = !DIDerivedType(tag: DW_TAG_typedef, name: "uint", file: !106, line: 57, baseType: !36) | ||
| !182 = !DIDerivedType(tag: DW_TAG_typedef, name: "XMFLOAT4", file: !106, line: 17, baseType: !36) | ||
| !304 = !DICompositeType(tag: DW_TAG_structure_type, name: "RayPayload", file: !106, line: 60, size: 160, align: 32, elements: !305) | ||
| !305 = !{!306, !307} | ||
| !306 = !DIDerivedType(tag: DW_TAG_member, name: "color", scope: !304, file: !106, line: 62, baseType: !182, size: 128, align: 32) | ||
| !307 = !DIDerivedType(tag: DW_TAG_member, name: "recursionDepth", scope: !304, file: !106, line: 63, baseType: !153, size: 32, align: 32, offset: 128) | ||
| !325 = distinct !DISubprogram(name: "HitWorldPosition", linkageName: "\01?HitWorldPosition@@YA?AV?$vector@M$02@@XZ", scope: !106, file: !106, line: 89, type: !326, scopeLine: 90, flags: DIFlagPrototyped, spFlags: DISPFlagDefinition) | ||
| !326 = !DISubroutineType(types: !327) | ||
| !327 = !{} | ||
| !661 = !DILocation(line: 0, scope: !325, inlinedAt: !662) | ||
| !662 = distinct !DILocation(line: 249, column: 34, scope: !325) | ||
| !665 = !DILocation(line: 91, column: 12, scope: !325, inlinedAt: !666) | ||
| !666 = distinct !DILocation(line: 239, column: 26, scope: !325) |
| @@ -0,0 +1,109 @@ | |||
|
|
|||
| @@ -0,0 +1,109 @@ | |||
|
|
|||
| # RUN: llc -mtriple=amdgcn-amd-amdpal -mcpu=gfx1150 -run-pass=si-wqm -o - %s | |||
Contributor
|
Can you elaborate on the purpose of this change as there is no description? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.