Skip to content

[NFC] Use std::move to avoid copy #134531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[NFC] Use std::move to avoid copy #134531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions llvm/include/llvm/CodeGen/SelectionDAGNodes.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3296,8 +3296,8 @@ namespace ISD {
std::function<bool(ConstantSDNode *)> Match,
bool AllowUndefs = false,
bool AllowTruncation = false) {
return matchUnaryPredicateImpl<ConstantSDNode>(Op, Match, AllowUndefs,
AllowTruncation);
return matchUnaryPredicateImpl<ConstantSDNode>(
Op, std::move(Match), AllowUndefs, AllowTruncation);
Copy link
Collaborator

@RKSimon RKSimon Apr 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting - what warning / linter picked this up?

}

/// Hook for matching ConstantFPSDNode predicate
Expand Down
2 changes: 1 addition & 1 deletion llvm/lib/Target/X86/X86ISelLowering.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41005,7 +41005,7 @@ static SDValue combineX86ShufflesRecursively(
resolveTargetShuffleFromZeroables(OpMask, OpUndef, OpZero,
ResolveKnownZeros);

Mask = OpMask;
Mask = std::move(OpMask);
Ops.append(OpInputs.begin(), OpInputs.end());
} else {
resolveTargetShuffleFromZeroables(OpMask, OpUndef, OpZero);
Expand Down
3 changes: 2 additions & 1 deletion llvm/utils/TableGen/SubtargetEmitter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1054,7 +1054,8 @@ void SubtargetEmitter::expandProcResources(
continue;
ConstRecVec SuperResources = PR->getValueAsListOfDefs("Resources");
bool AllContained =
all_of(SubResources, [SuperResources](const Record *SubResource) {
all_of(SubResources, [SuperResources = std::move(SuperResources)](
Copy link
Collaborator

@RKSimon RKSimon Apr 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not just [&SuperResources] ?

@kazutakahirata is there an STL version of this - something like is_all_contained(SuperResources,SubResources)?

const Record *SubResource) {
return is_contained(SuperResources, SubResource);
});
if (AllContained) {
Expand Down