-
Notifications
You must be signed in to change notification settings - Fork 15.3k
[AMDGPU] SIInstrInfo: Fix resultDependsOnExec for VOPC instructions #134629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
frederik-h
merged 7 commits into
llvm:main
from
frederik-h:siinstrinfo-resultdependsonexec-vopc
Apr 22, 2025
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
f2c2356
[AMDGPU] SIInstrInfo: Fix resultDependsOnExec for VOPC instructions
frederik-h b4820bc
Review changes
frederik-h cca5aff
Change behavior on missing vdst
frederik-h afa8d27
clang-format changes
frederik-h 75e5619
Update llvm/lib/Target/AMDGPU/SIInstrInfo.cpp
frederik-h fe8a37e
Rename test
frederik-h 5279c20
Sink MRI def
frederik-h File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py UTC_ARGS: --version 5 | ||
| # RUN: llc -mtriple=amdgcn -mcpu=gfx1010 -run-pass=machine-cse %s -o - | FileCheck %s | ||
|
|
||
| # Check only that V_CMP_EQ_U32_e32 does not lead to a crash. | ||
|
|
||
| --- | ||
| name: depends_on_exec_check_can_handle_vopc | ||
| tracksRegLiveness: true | ||
| body: | | ||
| bb.0: | ||
| ; CHECK-LABEL: name: depends_on_exec_check_can_handle_vopc | ||
| ; CHECK: [[DEF:%[0-9]+]]:vgpr_32 = IMPLICIT_DEF | ||
| ; CHECK-NEXT: V_CMP_EQ_U32_e32 1, killed undef [[DEF]], implicit-def $vcc_lo, implicit $exec | ||
| ; CHECK-NEXT: [[V_CNDMASK_B32_e32_:%[0-9]+]]:vgpr_32 = V_CNDMASK_B32_e32 16256, undef [[DEF]], implicit $vcc_lo, implicit $exec | ||
| ; CHECK-NEXT: [[V_LSHLREV_B32_e64_:%[0-9]+]]:vgpr_32 = V_LSHLREV_B32_e64 16, undef [[V_CNDMASK_B32_e32_]], implicit $exec | ||
| ; CHECK-NEXT: SI_RETURN | ||
| %0:vgpr_32 = IMPLICIT_DEF | ||
| V_CMP_EQ_U32_e32 1, killed undef %0, implicit-def $vcc, implicit $exec | ||
| %1:vgpr_32 = V_CNDMASK_B32_e32 16256, undef %0, implicit $vcc, implicit $exec | ||
| V_CMP_EQ_U32_e32 1, killed undef %0, implicit-def $vcc, implicit $exec | ||
| %2:vgpr_32 = V_CNDMASK_B32_e32 16256, undef %0, implicit $vcc, implicit $exec | ||
| %3:vgpr_32 = V_LSHLREV_B32_e64 16, killed undef %2, implicit $exec | ||
| %4:vgpr_32 = V_LSHLREV_B32_e64 16, killed undef %1, implicit $exec | ||
| SI_RETURN | ||
| ... |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.