-
Notifications
You must be signed in to change notification settings - Fork 14.7k
[KeyInstr][Clang] For range stmt atoms #134647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
5c7ac16
[KeyInstr][Clang] For range stmt atoms
OCHyams 254e88b
cc1 + nits
OCHyams 29bd054
style nits
OCHyams f01b5ff
fix body-with-cfg br atom, in line with for loop patch
OCHyams dbe31d9
Update clang/test/DebugInfo/KeyInstructions/for-range.cpp
OCHyams 4cbd286
Update clang/lib/CodeGen/CGStmt.cpp
OCHyams File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,87 @@ | ||
// RUN: %clang_cc1 -triple x86_64-linux-gnu -gkey-instructions %s -debug-info-kind=line-tables-only -emit-llvm -o - \ | ||
// RUN: | FileCheck %s | ||
|
||
// Perennial question: should the inc be its own source atom or not | ||
// (currently it is). | ||
|
||
// FIXME: See do.c and while.c regarding cmp and cond br groups. | ||
|
||
// The stores in the setup (stores to __RANGE1, __BEGIN1, __END1) are all | ||
// marked as Key. Unclear whether that's desirable. Keep for now as that's | ||
// least risky (at worst it introduces an unecessary step while debugging, | ||
OCHyams marked this conversation as resolved.
Show resolved
Hide resolved
|
||
// as opposed to potentially losing one we want). | ||
|
||
// Check the conditional branch (and the condition) in FOR_COND and | ||
// unconditional branch in FOR_BODY are Key Instructions. | ||
|
||
struct Range { | ||
int *begin(); | ||
int *end(); | ||
} r; | ||
|
||
// CHECK-LABEL: define dso_local void @_Z1av( | ||
// CHECK-SAME: ) #[[ATTR0:[0-9]+]] !dbg [[DBG10:![0-9]+]] { | ||
// CHECK-NEXT: [[ENTRY:.*:]] | ||
// CHECK-NEXT: [[__RANGE1:%.*]] = alloca ptr, align 8 | ||
// CHECK-NEXT: [[__BEGIN1:%.*]] = alloca ptr, align 8 | ||
// CHECK-NEXT: [[__END1:%.*]] = alloca ptr, align 8 | ||
// CHECK-NEXT: [[I:%.*]] = alloca i32, align 4 | ||
// CHECK-NEXT: store ptr @r, ptr [[__RANGE1]], align 8, !dbg [[DBG14:![0-9]+]] | ||
// CHECK-NEXT: [[CALL:%.*]] = call noundef ptr @_ZN5Range5beginEv(ptr noundef nonnull align 1 dereferenceable(1) @r), !dbg [[DBG15:![0-9]+]] | ||
// CHECK-NEXT: store ptr [[CALL]], ptr [[__BEGIN1]], align 8, !dbg [[DBG16:![0-9]+]] | ||
// CHECK-NEXT: [[CALL1:%.*]] = call noundef ptr @_ZN5Range3endEv(ptr noundef nonnull align 1 dereferenceable(1) @r), !dbg [[DBG17:![0-9]+]] | ||
// CHECK-NEXT: store ptr [[CALL1]], ptr [[__END1]], align 8, !dbg [[DBG18:![0-9]+]] | ||
// CHECK-NEXT: br label %[[FOR_COND:.*]], !dbg [[DBG19:![0-9]+]] | ||
// CHECK: [[FOR_COND]]: | ||
// CHECK-NEXT: [[TMP0:%.*]] = load ptr, ptr [[__BEGIN1]], align 8, !dbg [[DBG19]] | ||
// CHECK-NEXT: [[TMP1:%.*]] = load ptr, ptr [[__END1]], align 8, !dbg [[DBG19]] | ||
// CHECK-NEXT: [[CMP:%.*]] = icmp ne ptr [[TMP0]], [[TMP1]], !dbg [[DBG20:![0-9]+]] | ||
// CHECK-NEXT: br i1 [[CMP]], label %[[FOR_BODY:.*]], label %[[FOR_END:.*]], !dbg [[DBG21:![0-9]+]] | ||
// CHECK: [[FOR_BODY]]: | ||
// CHECK-NEXT: [[TMP2:%.*]] = load ptr, ptr [[__BEGIN1]], align 8, !dbg [[DBG19]] | ||
// CHECK-NEXT: [[TMP3:%.*]] = load i32, ptr [[TMP2]], align 4, !dbg [[DBG22:![0-9]+]] | ||
// CHECK-NEXT: store i32 [[TMP3]], ptr [[I]], align 4, !dbg [[DBG23:![0-9]+]] | ||
// CHECK-NEXT: br label %[[FOR_INC:.*]], !dbg [[DBG24:![0-9]+]] | ||
// CHECK: [[FOR_INC]]: | ||
// CHECK-NEXT: [[TMP4:%.*]] = load ptr, ptr [[__BEGIN1]], align 8, !dbg [[DBG19]] | ||
// CHECK-NEXT: [[INCDEC_PTR:%.*]] = getelementptr inbounds nuw i32, ptr [[TMP4]], i32 1, !dbg [[DBG25:![0-9]+]] | ||
// CHECK-NEXT: store ptr [[INCDEC_PTR]], ptr [[__BEGIN1]], align 8, !dbg [[DBG26:![0-9]+]] | ||
// CHECK-NEXT: br label %[[FOR_COND]], !dbg [[DBG19]], !llvm.loop | ||
// CHECK: [[FOR_END]]: | ||
// CHECK-NEXT: ret void, !dbg [[DBG30:![0-9]+]] | ||
// | ||
void a() { | ||
for (int i: r) | ||
; | ||
} | ||
|
||
// - Check the branch out of the body gets an atom group (and gets it correct | ||
// if there's ctrl-flow in the body). | ||
void b() { | ||
for (int i: r) { | ||
if (i) | ||
; | ||
// CHECK: entry: | ||
// CHECK: if.end: | ||
// CHECK-NEXT: br label %for.inc, !dbg [[b_br:!.*]] | ||
} | ||
} | ||
|
||
//. | ||
// CHECK: [[DBG14]] = !DILocation({{.*}}, atomGroup: 1, atomRank: 1) | ||
// CHECK: [[DBG15]] = !DILocation({{.*}}, atomGroup: 2, atomRank: 2) | ||
// CHECK: [[DBG16]] = !DILocation({{.*}}, atomGroup: 2, atomRank: 1) | ||
// CHECK: [[DBG17]] = !DILocation({{.*}}, atomGroup: 3, atomRank: 2) | ||
// CHECK: [[DBG18]] = !DILocation({{.*}}, atomGroup: 3, atomRank: 1) | ||
// CHECK: [[DBG19]] = !DILocation({{.*}}) | ||
// CHECK: [[DBG20]] = !DILocation({{.*}}, atomGroup: 4, atomRank: 1) | ||
// CHECK: [[DBG21]] = !DILocation({{.*}}, atomGroup: 5, atomRank: 1) | ||
// CHECK: [[DBG22]] = !DILocation({{.*}}, atomGroup: 6, atomRank: 2) | ||
// CHECK: [[DBG23]] = !DILocation({{.*}}, atomGroup: 6, atomRank: 1) | ||
// CHECK: [[DBG24]] = !DILocation({{.*}} atomGroup: 8, atomRank: 1) | ||
// CHECK: [[DBG25]] = !DILocation({{.*}}, atomGroup: 7, atomRank: 2) | ||
// CHECK: [[DBG26]] = !DILocation({{.*}}, atomGroup: 7, atomRank: 1) | ||
// CHECK: [[DBG30]] = !DILocation({{.*}}) | ||
// | ||
// CHECK: [[b_br]] = !DILocation({{.*}}, atomGroup: [[#]], atomRank: [[#]]) | ||
//. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.