Skip to content

Conversation

OCHyams
Copy link
Contributor

@OCHyams OCHyams commented Apr 7, 2025

[KeyInstr][Clang] Coerced store atoms

This patch is part of a stack that teaches Clang to generate Key Instructions
metadata for C and C++.

The Key Instructions project is introduced, including a "quick summary" section
at the top which adds context for this PR, here:
https://discourse.llvm.org/t/rfc-improving-is-stmt-placement-for-better-interactive-debugging/82668

The feature is only functional in LLVM if LLVM is built with CMake flag
LLVM_EXPERIMENTAL_KEY_INSTRUCTIONs. Eventually that flag will be removed.

The Clang-side work is demoed here:
#130943

[KeyInstr][Clang] Coerced to int atom

[KeyInstr][Clang] Coerced ptr to int atom

[KeyInstr][Clang] Coerce packed struct atom

[KeyInstr][Clang] Coerce through memory atom

This was referenced Apr 7, 2025
@OCHyams OCHyams marked this pull request as draft June 3, 2025 08:17
@OCHyams OCHyams changed the base branch from users/OCHyams/ki-clang-ret to main June 3, 2025 08:17
@OCHyams OCHyams marked this pull request as ready for review June 3, 2025 08:17
@OCHyams
Copy link
Contributor Author

OCHyams commented Jun 3, 2025

  • Changed base to main (sorry to everyone automatically added as reviewer - I forgot to change to Draft PR before changing base).
  • Removed Ret-atom checks (that PR hasn't been approved yet, want to land this one now it's approved).
  • Fixed broken run lines (broken in bad rebase earlier).
  • clang-formated

@OCHyams OCHyams merged commit 347273d into main Jun 3, 2025
6 of 15 checks passed
@OCHyams OCHyams deleted the users/OCHyams/ki-clang-coerce branch June 3, 2025 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clang:codegen IR generation bugs: mangling, exceptions, etc. clang Clang issues not falling into any other category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants