Skip to content

[DirectX] legalize powi #135228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025
Merged

[DirectX] legalize powi #135228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions llvm/lib/Target/DirectX/DXILIntrinsicExpansion.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ static bool isIntrinsicExpansion(Function &F) {
case Intrinsic::log:
case Intrinsic::log10:
case Intrinsic::pow:
case Intrinsic::powi:
case Intrinsic::dx_all:
case Intrinsic::dx_any:
case Intrinsic::dx_cross:
Expand Down Expand Up @@ -251,7 +252,7 @@ static Value *expandExpIntrinsic(CallInst *Orig) {
}

static Value *expandAnyOrAllIntrinsic(CallInst *Orig,
Intrinsic::ID intrinsicId) {
Intrinsic::ID IntrinsicId) {
Value *X = Orig->getOperand(0);
IRBuilder<> Builder(Orig);
Type *Ty = X->getType();
Expand Down Expand Up @@ -285,7 +286,7 @@ static Value *expandAnyOrAllIntrinsic(CallInst *Orig,
Result = Builder.CreateExtractElement(Cond, (uint64_t)0);
for (unsigned I = 1; I < XVec->getNumElements(); I++) {
Value *Elt = Builder.CreateExtractElement(Cond, I);
Result = ApplyOp(intrinsicId, Result, Elt);
Result = ApplyOp(IntrinsicId, Result, Elt);
}
}
return Result;
Expand Down Expand Up @@ -410,13 +411,16 @@ static Value *expandAtan2Intrinsic(CallInst *Orig) {
return Result;
}

static Value *expandPowIntrinsic(CallInst *Orig) {
static Value *expandPowIntrinsic(CallInst *Orig, Intrinsic::ID IntrinsicId) {

Value *X = Orig->getOperand(0);
Value *Y = Orig->getOperand(1);
Type *Ty = X->getType();
IRBuilder<> Builder(Orig);

if (IntrinsicId == Intrinsic::powi)
Y = Builder.CreateSIToFP(Y, Ty);

auto *Log2Call =
Builder.CreateIntrinsic(Ty, Intrinsic::log2, {X}, nullptr, "elt.log2");
auto *Mul = Builder.CreateFMul(Log2Call, Y);
Expand Down Expand Up @@ -542,7 +546,8 @@ static bool expandIntrinsic(Function &F, CallInst *Orig) {
Result = expandLog10Intrinsic(Orig);
break;
case Intrinsic::pow:
Result = expandPowIntrinsic(Orig);
case Intrinsic::powi:
Result = expandPowIntrinsic(Orig, IntrinsicId);
break;
case Intrinsic::dx_all:
case Intrinsic::dx_any:
Expand Down
26 changes: 26 additions & 0 deletions llvm/test/CodeGen/DirectX/pow.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,31 @@ entry:
ret half %elt.pow
}

define noundef float @powi_float(float noundef %a, i32 noundef %b) {
entry:
; CHECK: [[CAST:%.*]] = sitofp i32 %b to float
; DOPCHECK: call float @dx.op.unary.f32(i32 23, float %a)
; EXPCHECK: call float @llvm.log2.f32(float %a)
; CHECK: fmul float %{{.*}}, [[CAST]]
; DOPCHECK: call float @dx.op.unary.f32(i32 21, float %{{.*}})
; EXPCHECK: call float @llvm.exp2.f32(float %{{.*}})
%elt.powi = call float @llvm.powi.f32.i32(float %a, i32 %b)
ret float %elt.powi
}

define noundef half @powi_half(half noundef %a, i32 noundef %b) {
entry:
; CHECK: [[CAST:%.*]] = sitofp i32 %b to half
; DOPCHECK: call half @dx.op.unary.f16(i32 23, half %a)
; EXPCHECK: call half @llvm.log2.f16(half %a)
; CHECK: fmul half %{{.*}}, [[CAST]]
; DOPCHECK: call half @dx.op.unary.f16(i32 21, half %{{.*}})
; EXPCHECK: call half @llvm.exp2.f16(half %{{.*}})
%elt.powi = call half @llvm.powi.f16.i32(half %a, i32 %b)
ret half %elt.powi
}

declare half @llvm.pow.f16(half,half)
declare float @llvm.pow.f32(float,float)
declare half @llvm.powi.f16.i32(half,i32)
declare float @llvm.powi.f32.i32(float,i32)
Loading