Skip to content

[NFC][libclc] Refine clz to use __builtin_clzg #135301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[NFC][libclc] Refine clz to use __builtin_clzg #135301

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5992cc8
[NFC][libclc] Refine clz to use __builtin_clzg
wenju-he Apr 11, 2025
2be72b2
clang-format
wenju-he Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions libclc/clc/lib/generic/integer/clc_clz.cl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,35 +11,31 @@
#include <clc/internal/clc.h>

_CLC_OVERLOAD _CLC_DEF char __clc_clz(char x) {
return __clc_clz((ushort)(uchar)x) - 8;
return __clc_clz(__clc_as_uchar(x));
}

_CLC_OVERLOAD _CLC_DEF uchar __clc_clz(uchar x) {
return __clc_clz((ushort)x) - 8;
}
_CLC_OVERLOAD _CLC_DEF uchar __clc_clz(uchar x) { return __builtin_clzg(x, 8); }

_CLC_OVERLOAD _CLC_DEF short __clc_clz(short x) {
return x ? __builtin_clzs(x) : 16;
return __clc_clz(__clc_as_ushort(x));
}

_CLC_OVERLOAD _CLC_DEF ushort __clc_clz(ushort x) {
return x ? __builtin_clzs(x) : 16;
return __builtin_clzg(x, 16);
}

_CLC_OVERLOAD _CLC_DEF int __clc_clz(int x) {
return x ? __builtin_clz(x) : 32;
return __clc_clz(__clc_as_uint(x));
}

_CLC_OVERLOAD _CLC_DEF uint __clc_clz(uint x) {
return x ? __builtin_clz(x) : 32;
}
_CLC_OVERLOAD _CLC_DEF uint __clc_clz(uint x) { return __builtin_clzg(x, 32); }

_CLC_OVERLOAD _CLC_DEF long __clc_clz(long x) {
return x ? __builtin_clzl(x) : 64;
return __clc_clz(__clc_as_ulong(x));
}

_CLC_OVERLOAD _CLC_DEF ulong __clc_clz(ulong x) {
return x ? __builtin_clzl(x) : 64;
return __builtin_clzg(x, 64);
}

_CLC_UNARY_VECTORIZE(_CLC_OVERLOAD _CLC_DEF, char, __clc_clz, char)
Expand Down