[libclc] add ctz built-in implementation to clc and generic #135309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@frasercrmck please help to review? thanks. |
frasercrmck
reviewed
Apr 14, 2025
frasercrmck
approved these changes
Apr 15, 2025
Contributor
frasercrmck
left a comment
frasercrmck
left a comment
There was a problem hiding this comment.
LGTM.
I note that this uses __OPENCL_C_VERSION__ which technically isn't available for OpenCL 1.0 or 1.1. However, clang defines this macro even for those versions, so we have a consistent version checking mechanism. See here. I think it's okay to depend on clang-specific behaviour. We already rely on cl_clang_storage_class_specifiers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.