Skip to content

[AsmPrinter] Link .section_sizes to the correct section #135583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 14, 2025
Merged

[AsmPrinter] Link .section_sizes to the correct section #135583

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c2c473
[AsmPrinter] Link .section_sizes to the correct section
s-barannikov Apr 14, 2025
b612daf
Adapt the test to AArch64
s-barannikov Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1586,7 +1586,7 @@ void AsmPrinter::emitStackSizeSection(const MachineFunction &MF) {
return;

MCSection *StackSizeSection =
getObjFileLowering().getStackSizesSection(*getCurrentSection());
getObjFileLowering().getStackSizesSection(*MF.getSection());
if (!StackSizeSection)
return;

Expand Down
30 changes: 30 additions & 0 deletions llvm/test/CodeGen/SystemZ/stack-size-section.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,34 @@ define void @dynalloc(i32 %N) #0 {
ret void
}

; Check that .stack_sizes section is linked to the function's section (.text),
; and not to the section containing the jump table (.rodata).
; CHECK-LABEL: .section .stack_sizes,"o",@progbits,.text{{$}}
; CHECK-NEXT: .quad .Lfunc_begin4
; CHECK-NEXT: .ascii "\260!"
define i32 @jump_table(i32 %x) {
%arr = alloca [1024 x i32]
switch i32 %x, label %sw.epilog [
i32 0, label %sw.bb0
i32 1, label %sw.bb1
i32 2, label %sw.bb2
i32 3, label %sw.bb3
]

sw.bb0:
ret i32 0

sw.bb1:
ret i32 1

sw.bb2:
ret i32 2

sw.bb3:
ret i32 3

sw.epilog:
ret i32 -1
}

attributes #0 = { "frame-pointer"="all" }