[Test][Darwin] Disable test on watchos due to memory restraints #135671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
compiler-rt
compiler-rt:asan
Member
|
@llvm/pr-subscribers-compiler-rt-sanitizer Author: None (thetruestblue) ChangesBecause of the nature of this test (mmap stress-test) it tests too large of memory allocations to be stable on watchos. WatchOS has memory limits that can lead to the termination of this process before it reaches the limit set by the flag. It is guaranteed to occur if a test device is under heavy load. disable on watchOS. rdar://147222346 Full diff: https://github.com/llvm/llvm-project/pull/135671.diff 1 Files Affected:
diff --git a/compiler-rt/test/asan/TestCases/Posix/mmap_limit_mb.cpp b/compiler-rt/test/asan/TestCases/Posix/mmap_limit_mb.cpp
index 87ac5b2925ed0..ed187e4481a4f 100644
--- a/compiler-rt/test/asan/TestCases/Posix/mmap_limit_mb.cpp
+++ b/compiler-rt/test/asan/TestCases/Posix/mmap_limit_mb.cpp
@@ -1,5 +1,9 @@
// Test the mmap_limit_mb flag.
//
+// stress-test isn't reliable on watchOS due to space limitations
+// UNSUPPORTED: watchos
+//
+//
// RUN: %clangxx_asan -O2 %s -o %t
// RUN: %run %t 20 16
// RUN: %run %t 30 1000000
|
Because of the nature of this test (mmap stress-test) it tests too large of memory allocations to test on watchos. WatchOS has memory limits that can lead to the termination of this test before it reaches the limit set by the flag. We are going to disable on watchOS for now. rdar://147222346
thetruestblue
force-pushed
the
mmap-limit
branch
from
8bff740 to
9f83ac0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the nature of this test (mmap stress-test) it tests too large of memory allocations to be stable on watchos. WatchOS has memory limits that can lead to the termination of this process before it reaches the limit set by the flag. Typical only on devices that are under heavy load. disable on watchOS.
rdar://147222346