[webkit.UncountedLambdaCapturesChecker] Treat a call to lambda function via a variable as safe. #135688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on via a variable as safe. This PR makes the checker ignore a function call to lambda via a local variable.
llvmbot
added
clang
Member
|
@llvm/pr-subscribers-clang Author: Ryosuke Niwa (rniwa) ChangesThis PR makes the checker ignore a function call to lambda via a local variable. Full diff: https://github.com/llvm/llvm-project/pull/135688.diff 2 Files Affected:
diff --git a/clang/lib/StaticAnalyzer/Checkers/WebKit/RawPtrRefLambdaCapturesChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/WebKit/RawPtrRefLambdaCapturesChecker.cpp
index da403d591a2e2..0a658b59ad8c5 100644
--- a/clang/lib/StaticAnalyzer/Checkers/WebKit/RawPtrRefLambdaCapturesChecker.cpp
+++ b/clang/lib/StaticAnalyzer/Checkers/WebKit/RawPtrRefLambdaCapturesChecker.cpp
@@ -263,8 +263,6 @@ class RawPtrRefLambdaCapturesChecker
return;
DeclRefExprsToIgnore.insert(ArgRef);
LambdasToIgnore.insert(L);
- Checker->visitLambdaExpr(L, shouldCheckThis() && !hasProtectedThis(L),
- ClsType, /* ignoreParamVarDecl */ true);
}
bool hasProtectedThis(LambdaExpr *L) {
diff --git a/clang/test/Analysis/Checkers/WebKit/uncounted-lambda-captures.cpp b/clang/test/Analysis/Checkers/WebKit/uncounted-lambda-captures.cpp
index 36135973e78c0..cc3d27bbc1375 100644
--- a/clang/test/Analysis/Checkers/WebKit/uncounted-lambda-captures.cpp
+++ b/clang/test/Analysis/Checkers/WebKit/uncounted-lambda-captures.cpp
@@ -372,6 +372,14 @@ void trivial_lambda() {
trivial_lambda();
}
+bool call_lambda_var_decl() {
+ RefCountable* ref_countable = make_obj();
+ auto lambda = [&]() -> bool {
+ return ref_countable->next();
+ };
+ return lambda();
+}
+
void lambda_with_args(RefCountable* obj) {
auto trivial_lambda = [&](int v) {
obj->method();
|
Member
|
@llvm/pr-subscribers-clang-static-analyzer-1 Author: Ryosuke Niwa (rniwa) ChangesThis PR makes the checker ignore a function call to lambda via a local variable. Full diff: https://github.com/llvm/llvm-project/pull/135688.diff 2 Files Affected:
diff --git a/clang/lib/StaticAnalyzer/Checkers/WebKit/RawPtrRefLambdaCapturesChecker.cpp b/clang/lib/StaticAnalyzer/Checkers/WebKit/RawPtrRefLambdaCapturesChecker.cpp
index da403d591a2e2..0a658b59ad8c5 100644
--- a/clang/lib/StaticAnalyzer/Checkers/WebKit/RawPtrRefLambdaCapturesChecker.cpp
+++ b/clang/lib/StaticAnalyzer/Checkers/WebKit/RawPtrRefLambdaCapturesChecker.cpp
@@ -263,8 +263,6 @@ class RawPtrRefLambdaCapturesChecker
return;
DeclRefExprsToIgnore.insert(ArgRef);
LambdasToIgnore.insert(L);
- Checker->visitLambdaExpr(L, shouldCheckThis() && !hasProtectedThis(L),
- ClsType, /* ignoreParamVarDecl */ true);
}
bool hasProtectedThis(LambdaExpr *L) {
diff --git a/clang/test/Analysis/Checkers/WebKit/uncounted-lambda-captures.cpp b/clang/test/Analysis/Checkers/WebKit/uncounted-lambda-captures.cpp
index 36135973e78c0..cc3d27bbc1375 100644
--- a/clang/test/Analysis/Checkers/WebKit/uncounted-lambda-captures.cpp
+++ b/clang/test/Analysis/Checkers/WebKit/uncounted-lambda-captures.cpp
@@ -372,6 +372,14 @@ void trivial_lambda() {
trivial_lambda();
}
+bool call_lambda_var_decl() {
+ RefCountable* ref_countable = make_obj();
+ auto lambda = [&]() -> bool {
+ return ref_countable->next();
+ };
+ return lambda();
+}
+
void lambda_with_args(RefCountable* obj) {
auto trivial_lambda = [&](int v) {
obj->method();
|
Contributor
Author
|
Thanks for the review! |
rniwa
added a commit
to rniwa/llvm-project
that referenced
this pull request
Apr 25, 2025
…on via a variable as safe. (llvm#135688) This PR makes the checker ignore a function call to lambda via a local variable.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
…on via a variable as safe. (llvm#135688) This PR makes the checker ignore a function call to lambda via a local variable.
rniwa
added a commit
to rniwa/llvm-project
that referenced
this pull request
Aug 21, 2025
…on via a variable as safe. (llvm#135688) This PR makes the checker ignore a function call to lambda via a local variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the checker ignore a function call to lambda via a local variable.