Skip to content

Conversation

@YonahGoldberg
Copy link
Contributor

This was already declared in NVPTX.h and I accidentally added it back in #134416.

@YonahGoldberg
Copy link
Contributor Author

@AlexMaclean @Artem-B

@llvmbot
Copy link
Member

llvmbot commented Apr 15, 2025

@llvm/pr-subscribers-backend-nvptx

Author: Yonah Goldberg (YonahGoldberg)

Changes

This was already declared in NVPTX.h and I accidentally added it back in #134416.


Full diff: https://github.com/llvm/llvm-project/pull/135825.diff

1 Files Affected:

  • (modified) llvm/lib/Target/NVPTX/NVVMReflect.cpp (-4)
diff --git a/llvm/lib/Target/NVPTX/NVVMReflect.cpp b/llvm/lib/Target/NVPTX/NVVMReflect.cpp
index 7273b30e4ae2e..30b522efa4361 100644
--- a/llvm/lib/Target/NVPTX/NVVMReflect.cpp
+++ b/llvm/lib/Target/NVPTX/NVVMReflect.cpp
@@ -52,10 +52,6 @@ using namespace llvm;
 
 #define DEBUG_TYPE "nvvm-reflect"
 
-namespace llvm {
-void initializeNVVMReflectLegacyPassPass(PassRegistry &);
-} // namespace llvm
-
 namespace {
 class NVVMReflect {
   // Map from reflect function call arguments to the value to replace the call

Copy link
Member

@AlexMaclean AlexMaclean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexMaclean
Copy link
Member

Merging on behalf of @YonahGoldberg at his request offline.

@AlexMaclean AlexMaclean merged commit ef1abbe into llvm:main Apr 16, 2025
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants