[lldb][nfc] Remove redundant check in if statement #135869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already check this boolean in the `if` statement two lines above.
Member
|
@llvm/pr-subscribers-lldb Author: Felipe de Azevedo Piovezan (felipepiovezan) ChangesWe already check this boolean in the Full diff: https://github.com/llvm/llvm-project/pull/135869.diff 1 Files Affected:
diff --git a/lldb/source/Target/ThreadPlanStepInRange.cpp b/lldb/source/Target/ThreadPlanStepInRange.cpp
index 8a2417e9da326..0e93691de68af 100644
--- a/lldb/source/Target/ThreadPlanStepInRange.cpp
+++ b/lldb/source/Target/ThreadPlanStepInRange.cpp
@@ -370,7 +370,7 @@ bool ThreadPlanStepInRange::DefaultShouldStopHereCallback(
if (!should_stop_here)
return false;
- if (should_stop_here && current_plan->GetKind() == eKindStepInRange &&
+ if (current_plan->GetKind() == eKindStepInRange &&
operation == eFrameCompareYounger) {
ThreadPlanStepInRange *step_in_range_plan =
static_cast<ThreadPlanStepInRange *>(current_plan);
|
felipepiovezan
added a commit
to felipepiovezan/llvm-project
that referenced
this pull request
Apr 17, 2025
We already check this boolean in the `if` statement two lines above.
felipepiovezan
added a commit
to felipepiovezan/llvm-project
that referenced
this pull request
Apr 17, 2025
We already check this boolean in the `if` statement two lines above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already check this boolean in the
ifstatement two lines above.