Skip to content

[SPIR-V] Fix OpVectorShuffle operands on load #135954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025
Merged

[SPIR-V] Fix OpVectorShuffle operands on load #135954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbeaab9
[SPIR-V] Fix OpVectorShuffle operands on load
Keenuts Apr 16, 2025
7b45caf
Merge branch 'main' into fix-ptrcast-load-vecshuffle
Keenuts Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions llvm/lib/Target/SPIRV/SPIRVLegalizePointerCast.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,9 @@ class SPIRVLegalizePointerCast : public FunctionPass {
LoadInst *NewLoad = B.CreateLoad(SourceType, Source);
buildAssignType(B, SourceType, NewLoad);

SmallVector<int> Mask(/* Size= */ TargetType->getNumElements(),
/* Value= */ 0);
SmallVector<int> Mask(/* Size= */ TargetType->getNumElements());
for (unsigned I = 0; I < TargetType->getNumElements(); ++I)
Mask[I] = I;
Value *Output = B.CreateShuffleVector(NewLoad, NewLoad, Mask);
buildAssignType(B, TargetType, Output);
return Output;
Expand Down
8 changes: 4 additions & 4 deletions llvm/test/CodeGen/SPIRV/pointers/getelementptr-downcast-vector.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ define internal spir_func <3 x i32> @foo(ptr addrspace(10) %a) {
; partial loading of a vector: v4 -> v3.
%2 = load <3 x i32>, ptr addrspace(10) %1, align 16
; CHECK: %[[#load:]] = OpLoad %[[#v4]] %[[#tmp]] Aligned 16
; CHECK: %[[#val:]] = OpVectorShuffle %[[#v3]] %[[#load]] %[[#load]] 0 0 0
; CHECK: %[[#val:]] = OpVectorShuffle %[[#v3]] %[[#load]] %[[#load]] 0 1 2

ret <3 x i32> %2
; CHECK: OpReturnValue %[[#val]]
Expand All @@ -33,7 +33,7 @@ define internal spir_func <3 x i32> @fooDefault(ptr %a) {
; partial loading of a vector: v4 -> v3.
%2 = load <3 x i32>, ptr %1, align 16
; CHECK: %[[#load:]] = OpLoad %[[#v4]] %[[#tmp]] Aligned 16
; CHECK: %[[#val:]] = OpVectorShuffle %[[#v3]] %[[#load]] %[[#load]] 0 0 0
; CHECK: %[[#val:]] = OpVectorShuffle %[[#v3]] %[[#load]] %[[#load]] 0 1 2

ret <3 x i32> %2
; CHECK: OpReturnValue %[[#val]]
Expand All @@ -47,7 +47,7 @@ define internal spir_func <3 x i32> @fooBounds(ptr %a) {
; partial loading of a vector: v4 -> v3.
%2 = load <3 x i32>, ptr %1, align 16
; CHECK: %[[#load:]] = OpLoad %[[#v4]] %[[#tmp]] Aligned 16
; CHECK: %[[#val:]] = OpVectorShuffle %[[#v3]] %[[#load]] %[[#load]] 0 0 0
; CHECK: %[[#val:]] = OpVectorShuffle %[[#v3]] %[[#load]] %[[#load]] 0 1 2

ret <3 x i32> %2
; CHECK: OpReturnValue %[[#val]]
Expand All @@ -61,7 +61,7 @@ define internal spir_func <2 x i32> @bar(ptr addrspace(10) %a) {
; partial loading of a vector: v4 -> v2.
%2 = load <2 x i32>, ptr addrspace(10) %1, align 16
; CHECK: %[[#load:]] = OpLoad %[[#v4]] %[[#tmp]] Aligned 16
; CHECK: %[[#val:]] = OpVectorShuffle %[[#v2]] %[[#load]] %[[#load]] 0 0
; CHECK: %[[#val:]] = OpVectorShuffle %[[#v2]] %[[#load]] %[[#load]] 0 1

ret <2 x i32> %2
; CHECK: OpReturnValue %[[#val]]
Expand Down
Loading