[mlir][linalg][NFC] Update elementwise docs to match op name #135999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates linalg.elementwise op description to replace older abbreviated mnemonic with its current form.
adam-smnk
requested review from
dcaballe,
nicolasvasilache and
rengolin
as code owners
Member
|
@llvm/pr-subscribers-mlir Author: Adam Siemieniuk (adam-smnk) ChangesUpdates linalg.elementwise op description to replace older abbreviated mnemonic with its current form. Full diff: https://github.com/llvm/llvm-project/pull/135999.diff 1 Files Affected:
diff --git a/mlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOps.td b/mlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOps.td
index 308e39a9a51e1..b9edcc92e81a9 100644
--- a/mlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOps.td
+++ b/mlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOps.td
@@ -565,18 +565,18 @@ def ElementwiseOp : LinalgStructuredBase_Op<"elementwise", [
Example:
- Defining a unary linalg.elemwise with default indexing-map:
+ Defining a unary linalg.elementwise with default indexing-map:
```mlir
- %exp = linalg.elemwise
- kind=#linalg.elemwise_kind<exp>
+ %exp = linalg.elementwise
+ kind=#linalg.elementwise_kind<exp>
ins(%x : tensor<4x16x8xf32>)
outs(%y: tensor<4x16x8xf32>) -> tensor<4x16x8xf32>
```
- Defining a binary linalg.elemwise with user-defined indexing-map:
+ Defining a binary linalg.elementwise with user-defined indexing-map:
```mlir
- %add = linalg.elemwise
- kind=#linalg.elemwise_kind<add>
+ %add = linalg.elementwise
+ kind=#linalg.elementwise_kind<add>
indexing_maps = [#transpose, #broadcast, #identity]
ins(%exp, %arg1 : tensor<4x16x8xf32>, tensor<4x16xf32>)
outs(%arg2: tensor<4x8x16xf32>) -> tensor<4x8x16xf32>
|
Member
|
@llvm/pr-subscribers-mlir-linalg Author: Adam Siemieniuk (adam-smnk) ChangesUpdates linalg.elementwise op description to replace older abbreviated mnemonic with its current form. Full diff: https://github.com/llvm/llvm-project/pull/135999.diff 1 Files Affected:
diff --git a/mlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOps.td b/mlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOps.td
index 308e39a9a51e1..b9edcc92e81a9 100644
--- a/mlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOps.td
+++ b/mlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOps.td
@@ -565,18 +565,18 @@ def ElementwiseOp : LinalgStructuredBase_Op<"elementwise", [
Example:
- Defining a unary linalg.elemwise with default indexing-map:
+ Defining a unary linalg.elementwise with default indexing-map:
```mlir
- %exp = linalg.elemwise
- kind=#linalg.elemwise_kind<exp>
+ %exp = linalg.elementwise
+ kind=#linalg.elementwise_kind<exp>
ins(%x : tensor<4x16x8xf32>)
outs(%y: tensor<4x16x8xf32>) -> tensor<4x16x8xf32>
```
- Defining a binary linalg.elemwise with user-defined indexing-map:
+ Defining a binary linalg.elementwise with user-defined indexing-map:
```mlir
- %add = linalg.elemwise
- kind=#linalg.elemwise_kind<add>
+ %add = linalg.elementwise
+ kind=#linalg.elementwise_kind<add>
indexing_maps = [#transpose, #broadcast, #identity]
ins(%exp, %arg1 : tensor<4x16x8xf32>, tensor<4x16xf32>)
outs(%arg2: tensor<4x8x16xf32>) -> tensor<4x8x16xf32>
|
rengolin
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates linalg.elementwise op description to replace older abbreviated mnemonic with its current form.