[flang][OpenACC] Fix crash due to truncated scope source range #136206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A combined construct needs to ensure that the source range of their initial statement is part of the source range of their scope. Fixes llvm#136076.
llvmbot
added
flang
Member
|
@llvm/pr-subscribers-flang-semantics Author: Peter Klausler (klausler) ChangesA combined construct needs to ensure that the source range of their initial statement is part of the source range of their scope. Fixes #136076. Full diff: https://github.com/llvm/llvm-project/pull/136206.diff 1 Files Affected:
diff --git a/flang/lib/Semantics/resolve-names.cpp b/flang/lib/Semantics/resolve-names.cpp
index 74367b5229548..a04d976c69f05 100644
--- a/flang/lib/Semantics/resolve-names.cpp
+++ b/flang/lib/Semantics/resolve-names.cpp
@@ -1384,6 +1384,20 @@ class AccVisitor : public virtual DeclarationVisitor {
void Post(const parser::AccEndBlockDirective &) {
messageHandler().set_currStmtSource(std::nullopt);
}
+ bool Pre(const parser::AccBeginCombinedDirective &x) {
+ AddAccSourceRange(x.source);
+ return true;
+ }
+ void Post(const parser::AccBeginCombinedDirective &) {
+ messageHandler().set_currStmtSource(std::nullopt);
+ }
+ bool Pre(const parser::AccEndCombinedDirective &x) {
+ AddAccSourceRange(x.source);
+ return true;
+ }
+ void Post(const parser::AccEndCombinedDirective &) {
+ messageHandler().set_currStmtSource(std::nullopt);
+ }
bool Pre(const parser::AccBeginLoopDirective &x) {
AddAccSourceRange(x.source);
return true;
|
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
…136206) A combined construct needs to ensure that the source range of their initial statement is part of the source range of their scope. Fixes llvm#136076.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A combined construct needs to ensure that the source range of their initial statement is part of the source range of their scope.
Fixes #136076.