Skip to content

[lldb-dap] Remove an incorrect assumption on reverse requests. #136210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2025
Merged

[lldb-dap] Remove an incorrect assumption on reverse requests. #136210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions lldb/packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,25 +343,21 @@ def send_recv(self, command):
self.send_packet(
{
"type": "response",
"seq": 0,
"request_seq": response_or_request["seq"],
"success": True,
"command": "runInTerminal",
"body": {},
},
set_sequence=False,
)
elif response_or_request["command"] == "startDebugging":
self.send_packet(
{
"type": "response",
"seq": 0,
"request_seq": response_or_request["seq"],
"success": True,
"command": "startDebugging",
"body": {},
},
set_sequence=False,
)
else:
desc = 'unknown reverse request "%s"' % (
Expand Down
5 changes: 0 additions & 5 deletions lldb/tools/lldb-dap/Protocol/ProtocolBase.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,11 +163,6 @@ bool fromJSON(json::Value const &Params, Response &R, json::Path P) {
return false;
}

if (seq != 0) {
P.field("seq").report("expected to be '0'");
return false;
}

if (R.command.empty()) {
P.field("command").report("expected to not be ''");
return false;
Expand Down
Loading