Skip to content

[libc][bazel] Enforce that libc hand-in-hand libs are headers-only. #136219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vonosmas merged 1 commit into from
Apr 17, 2025
Merged

[libc][bazel] Enforce that libc hand-in-hand libs are headers-only. #136219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 15 additions & 13 deletions utils/bazel/llvm-project-overlay/libc/libc_build_rules.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,12 +123,15 @@ _get_libc_info_aspect = aspect(
)

def _libc_srcs_filegroup_impl(ctx):
return DefaultInfo(
files = depset(transitive = [
fn[LibcLibraryInfo].srcs
for fn in ctx.attr.libs
]),
)
srcs = depset(transitive = [
fn[LibcLibraryInfo].srcs
for fn in ctx.attr.libs
])
if ctx.attr.enforce_headers_only:
paths = [f.short_path for f in srcs.to_list() if f.extension != "h"]
if paths:
fail("Unexpected non-header files: {}".format(paths))
return DefaultInfo(files = srcs)

_libc_srcs_filegroup = rule(
doc = "Returns all sources for building the specified libraries.",
Expand All @@ -138,6 +141,7 @@ _libc_srcs_filegroup = rule(
mandatory = True,
aspects = [_get_libc_info_aspect],
),
"enforce_headers_only": attr.bool(default = False),
},
)

Expand Down Expand Up @@ -218,6 +222,7 @@ def libc_header_library(name, hdrs, deps = [], **kwargs):
_libc_srcs_filegroup(
name = name + "_hdr_deps",
libs = deps,
enforce_headers_only = True,
)

_libc_textual_hdrs_filegroup(
Expand All @@ -231,13 +236,10 @@ def libc_header_library(name, hdrs, deps = [], **kwargs):

native.cc_library(
name = name,
# Technically speaking, we should put _hdr_deps in srcs, as they are
# not a part of this cc_library interface. However, we keep it here to
# workaround the presence of .cpp files in _hdr_deps - we need to
# fix that and enforce their absence, since libc_header_library
# should be header-only and not produce any object files.
# See PR #133126 which tracks it.
hdrs = hdrs + [":" + name + "_hdr_deps"],
hdrs = hdrs,
# We put _hdr_deps in srcs, as they are not a part of this cc_library
# interface, but instead are used to implement shared headers.
srcs = [":" + name + "_hdr_deps"],
deps = [":" + name + "_textual_hdr_library"],
# copts don't really matter, since it's a header-only library, but we
# need proper -I flags for header validation, which are specified in
Expand Down
Loading