llvm-reduce: Avoid using constantdata uselistorder in thinlto test #136288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also demonstrates a bug that's a consequence of the two different paths for the single and multithreaded cases. The parallel path goes through bitcode serialization and does preserve the uselistorder. It therefore survives and we can observe a reduced uselistorder with deleted instructions. In the CloneModule case, nothing is reduced.
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Author
arsenm
deleted the
users/arsenm/llvm-reduce/adjust-thinlto-uselistorder-test
branch
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
…lvm#136288) This also demonstrates a bug that's a consequence of the two different paths for the single and multithreaded cases. The parallel path goes through bitcode serialization and does preserve the uselistorder. It therefore survives and we can observe a reduced uselistorder with deleted instructions. In the CloneModule case, nothing is reduced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also demonstrates a bug that's a consequence of the two different
paths for the single and multithreaded cases. The parallel path goes
through bitcode serialization and does preserve the uselistorder. It
therefore survives and we can observe a reduced uselistorder with deleted
instructions. In the CloneModule case, nothing is reduced.