[mlir] harden transform.test_emit_remark_and_erase #136307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Executing this transform op may crash when the payload op is not erasable. Guard against that. Since this is a test op, no additional test is defined. Fixes llvm#128323.
Member
|
@llvm/pr-subscribers-mlir Author: Oleksandr "Alex" Zinenko (ftynse) ChangesExecuting this transform op may crash when the payload op is not erasable. Guard against that. Since this is a test op, no additional test is defined. Fixes #128323. Full diff: https://github.com/llvm/llvm-project/pull/136307.diff 1 Files Affected:
diff --git a/mlir/test/lib/Dialect/Transform/TestTransformDialectExtension.cpp b/mlir/test/lib/Dialect/Transform/TestTransformDialectExtension.cpp
index face4de8e27d3..cdf44c2959d50 100644
--- a/mlir/test/lib/Dialect/Transform/TestTransformDialectExtension.cpp
+++ b/mlir/test/lib/Dialect/Transform/TestTransformDialectExtension.cpp
@@ -346,8 +346,11 @@ DiagnosedSilenceableFailure mlir::test::TestEmitRemarkAndEraseOperandOp::apply(
transform::TransformRewriter &rewriter,
transform::TransformResults &results, transform::TransformState &state) {
emitRemark() << getRemark();
- for (Operation *op : state.getPayloadOps(getTarget()))
+ for (Operation *op : state.getPayloadOps(getTarget())) {
+ if (!op->getUses().empty())
+ return emitSilenceableError() << "cannot erase an op that has uses";
rewriter.eraseOp(op);
+ }
if (getFailAfterErase())
return emitSilenceableError() << "silenceable error";
|
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
Executing this transform op may crash when the payload op is not erasable. Guard against that. Since this is a test op, no additional test is defined. Fixes llvm#128323.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Executing this transform op may crash when the payload op is not erasable. Guard against that. Since this is a test op, no additional test is defined.
Fixes #128323.