Skip to content

[Clang] disallow use of attributes before extern template declarations #136328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 21, 2025
Merged

[Clang] disallow use of attributes before extern template declarations #136328

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0729ae4
[Clang] disallow use of attributes before extern template declarations
a-tarasyuk Apr 18, 2025
a6ad92e
add more test cases
a-tarasyuk Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions clang/docs/ReleaseNotes.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,9 @@ related warnings within the method body.
particularly relevant for AMDGPU targets, where they map to corresponding IR
metadata.

- Clang now disallows the use of attributes applied before an
``extern template`` declaration (#GH79893).

Improvements to Clang's diagnostics
-----------------------------------

Expand Down
1 change: 1 addition & 0 deletions clang/lib/Parse/Parser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1049,6 +1049,7 @@ Parser::ParseExternalDeclaration(ParsedAttributes &Attrs,

case tok::kw_extern:
if (getLangOpts().CPlusPlus && NextToken().is(tok::kw_template)) {
ProhibitAttributes(Attrs);
// Extern templates
SourceLocation ExternLoc = ConsumeToken();
SourceLocation TemplateLoc = ConsumeToken();
Expand Down
6 changes: 6 additions & 0 deletions clang/test/Parser/extern-template-attributes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
// RUN: %clang_cc1 -std=c++17 -verify %s

template <class>
struct S {};

[[deprecated]] extern template struct S<int>; // expected-error {{an attribute list cannot appear here}}
Loading