[Fuchsia] Disable PIC #136376
Merged
[Fuchsia] Disable PIC #136376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We aren't distributing any shared libraries so we don't need PIC and using PIE instead of PIC can improve performance.
Member
|
@llvm/pr-subscribers-clang Author: Petr Hosek (petrhosek) ChangesWe aren't distributing any shared libraries so we don't need PIC and using PIE instead of PIC can improve performance. Full diff: https://github.com/llvm/llvm-project/pull/136376.diff 1 Files Affected:
diff --git a/clang/cmake/caches/Fuchsia-stage2.cmake b/clang/cmake/caches/Fuchsia-stage2.cmake
index e10855f5ef31b..c483955f7ff26 100644
--- a/clang/cmake/caches/Fuchsia-stage2.cmake
+++ b/clang/cmake/caches/Fuchsia-stage2.cmake
@@ -18,6 +18,7 @@ set(LLVM_ENABLE_LIBEDIT OFF CACHE BOOL "")
set(LLVM_ENABLE_LLD ON CACHE BOOL "")
set(LLVM_ENABLE_LTO ON CACHE BOOL "")
set(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR ON CACHE BOOL "")
+set(LLVM_ENABLE_PIC OFF CACHE BOOL "")
set(LLVM_ENABLE_PLUGINS OFF CACHE BOOL "")
set(LLVM_ENABLE_UNWIND_TABLES OFF CACHE BOOL "")
set(LLVM_ENABLE_Z3_SOLVER OFF CACHE BOOL "")
|
ilovepi
approved these changes
Apr 18, 2025
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/186/builds/8393 Here is the relevant piece of the build log for the reference |
gulfemsavrun
added a commit
that referenced
this pull request
Apr 21, 2025
This reverts commit 846986f.
gulfemsavrun
added a commit
that referenced
this pull request
Apr 21, 2025
Reverts #136376 because it broke Fuchsia Clang toolchain builders.
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
May 6, 2025
Reverts llvm/llvm-project#136376 because it broke Fuchsia Clang toolchain builders.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
We aren't distributing any shared libraries so we don't need PIC and using PIE instead of PIC can improve performance.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
Reverts llvm#136376 because it broke Fuchsia Clang toolchain builders.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We aren't distributing any shared libraries so we don't need PIC and using PIE instead of PIC can improve performance.