Skip to content

[BOLT] Don't choke on nobits symbols #136384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2025
Merged

[BOLT] Don't choke on nobits symbols #136384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions bolt/lib/Rewrite/RewriteInstance.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1055,10 +1055,11 @@ void RewriteInstance::discoverFileObjects() {
continue;
}

if (!Section->isText()) {
if (!Section->isText() || Section->isVirtual()) {
assert(SymbolType != SymbolRef::ST_Function &&
"unexpected function inside non-code section");
LLVM_DEBUG(dbgs() << "BOLT-DEBUG: rejecting as symbol is not in code\n");
LLVM_DEBUG(dbgs() << "BOLT-DEBUG: rejecting as symbol is not in code or "
"is in nobits section\n");
registerName(SymbolSize);
continue;
}
Expand Down
24 changes: 24 additions & 0 deletions bolt/test/X86/nobits-symbol.s
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
## Check that llvm-bolt doesn't choke on symbols defined in nobits sections.

# RUN: llvm-mc -filetype=obj -triple x86_64-unknown-unknown %s -o %t.o
# RUN: %clang %cflags %t.o -o %t.exe
# RUN: llvm-bolt %t.exe -o %t
#

.type symbol_in_nobits,@object
.section .my.nobits.section,"awx",@nobits
.globl symbol_in_nobits
.p2align 4, 0x0
symbol_in_nobits:
.zero 0x100000
.size symbol_in_nobits, 0x100000

.text
.globl main
.type main, %function
main:
.cfi_startproc
.LBB06:
retq
.cfi_endproc
.size main, .-main
Loading