Skip to content

Conversation

@ilovepi
Copy link
Contributor

@ilovepi ilovepi commented Apr 19, 2025

No description provided.

Copy link
Contributor Author

ilovepi commented Apr 19, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ilovepi ilovepi marked this pull request as ready for review April 19, 2025 01:04
@llvmbot
Copy link
Member

llvmbot commented Apr 19, 2025

@llvm/pr-subscribers-clang-tools-extra

Author: Paul Kirth (ilovepi)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/136390.diff

1 Files Affected:

  • (modified) clang-tools-extra/clang-doc/BitcodeReader.cpp (+3-3)
diff --git a/clang-tools-extra/clang-doc/BitcodeReader.cpp b/clang-tools-extra/clang-doc/BitcodeReader.cpp
index 1f2fb0a8b2b85..03715192a0016 100644
--- a/clang-tools-extra/clang-doc/BitcodeReader.cpp
+++ b/clang-tools-extra/clang-doc/BitcodeReader.cpp
@@ -46,7 +46,7 @@ llvm::Error decodeRecord(const Record &R, int &Field, llvm::StringRef Blob) {
   if (R[0] > INT_MAX)
     return llvm::createStringError(llvm::inconvertibleErrorCode(),
                                    "integer too large to parse");
-  Field = (int)R[0];
+  Field = static_cast<int>(R[0]);
   return llvm::Error::success();
 }
 
@@ -85,7 +85,7 @@ llvm::Error decodeRecord(const Record &R, std::optional<Location> &Field,
   if (R[0] > INT_MAX)
     return llvm::createStringError(llvm::inconvertibleErrorCode(),
                                    "integer too large to parse");
-  Field.emplace((int)R[0], Blob, (bool)R[1]);
+  Field.emplace(static_cast<int>(R[0]), Blob, static_cast<bool>(R[1]));
   return llvm::Error::success();
 }
 
@@ -135,7 +135,7 @@ llvm::Error decodeRecord(const Record &R,
   if (R[0] > INT_MAX)
     return llvm::createStringError(llvm::inconvertibleErrorCode(),
                                    "integer too large to parse");
-  Field.emplace_back((int)R[0], Blob, (bool)R[1]);
+  Field.emplace_back(static_cast<int>(R[0]), Blob, static_cast<bool>(R[1]));
   return llvm::Error::success();
 }
 

@ilovepi ilovepi changed the title [clang-doc] Avoid C-style casts [clang-doc][NFC] Avoid C-style casts Apr 19, 2025
Copy link
Contributor Author

ilovepi commented Apr 19, 2025

Merge activity

  • Apr 19, 2:32 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Apr 19, 2:34 AM EDT: A user merged this pull request with Graphite.

@ilovepi ilovepi merged commit 8376edb into main Apr 19, 2025
15 checks passed
@ilovepi ilovepi deleted the users/ilovepi/avoid-cstyle-cast branch April 19, 2025 06:34
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants