Skip to content

Conversation

@zyn0217
Copy link
Contributor

@zyn0217 zyn0217 commented Apr 19, 2025

This macro appears to have been introduced accidentally and isn't used anywhere.

This macro appears to have been introduced accidentally and isn't used
anywhere.
@zyn0217 zyn0217 added the skip-precommit-approval PR for CI feedback, not intended for review label Apr 19, 2025
@llvmbot llvmbot added clang Clang issues not falling into any other category clang:frontend Language frontend issues, e.g. anything involving "Sema" labels Apr 19, 2025
@llvmbot
Copy link
Member

llvmbot commented Apr 19, 2025

@llvm/pr-subscribers-clang

Author: Younan Zhang (zyn0217)

Changes

This macro appears to have been introduced accidentally and isn't used anywhere.


Full diff: https://github.com/llvm/llvm-project/pull/136400.diff

1 Files Affected:

  • (modified) clang/lib/AST/ExprConstant.cpp (-2)
diff --git a/clang/lib/AST/ExprConstant.cpp b/clang/lib/AST/ExprConstant.cpp
index b14ff21a8ebc2..80b86a7a8c142 100644
--- a/clang/lib/AST/ExprConstant.cpp
+++ b/clang/lib/AST/ExprConstant.cpp
@@ -67,8 +67,6 @@
 #include <functional>
 #include <optional>
 
-#define DEBUG_TYPE "exprconstant"
-
 using namespace clang;
 using llvm::APFixedPoint;
 using llvm::APInt;

@zyn0217
Copy link
Contributor Author

zyn0217 commented Apr 19, 2025

Actually it's used :(

/var/lib/buildkite-agent/builds/linux-56-59b8f5d88-5b8n6-1/llvm-project/github-pull-requests/clang/lib/AST/ExprConstant.cpp:11780:3: error: use of undeclared identifier 'DEBUG_TYPE'
  | LLVM_DEBUG(llvm::dbgs() << "The number of elements to initialize: "
  |  

@zyn0217 zyn0217 closed this Apr 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clang:frontend Language frontend issues, e.g. anything involving "Sema" clang Clang issues not falling into any other category skip-precommit-approval PR for CI feedback, not intended for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants