Skip to content

Conversation

@ilovepi
Copy link
Contributor

@ilovepi ilovepi commented Apr 19, 2025

No description provided.

Copy link
Contributor Author

ilovepi commented Apr 19, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@llvmbot
Copy link
Member

llvmbot commented Apr 19, 2025

@llvm/pr-subscribers-clang-tools-extra

Author: Paul Kirth (ilovepi)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/136443.diff

1 Files Affected:

  • (modified) clang-tools-extra/clang-doc/Serialize.cpp (+1-1)
diff --git a/clang-tools-extra/clang-doc/Serialize.cpp b/clang-tools-extra/clang-doc/Serialize.cpp
index 1dcccf3c3c2ab..2fef901a91a7b 100644
--- a/clang-tools-extra/clang-doc/Serialize.cpp
+++ b/clang-tools-extra/clang-doc/Serialize.cpp
@@ -261,7 +261,7 @@ static bool isPublic(const clang::AccessSpecifier AS,
                      const clang::Linkage Link) {
   if (AS == clang::AccessSpecifier::AS_private)
     return false;
-  else if ((Link == clang::Linkage::Module) ||
+  if ((Link == clang::Linkage::Module) ||
            (Link == clang::Linkage::External))
     return true;
   return false; // otherwise, linkage is some form of internal linkage

@github-actions
Copy link

github-actions bot commented Apr 19, 2025

✅ With the latest revision this PR passed the C/C++ code formatter.

@ilovepi ilovepi force-pushed the users/ilovepi/else-after-ret branch from e8723ee to 74b930e Compare April 23, 2025 15:20
Copy link
Contributor Author

ilovepi commented Apr 23, 2025

Merge activity

  • Apr 23, 1:38 PM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Apr 23, 1:40 PM EDT: A user merged this pull request with Graphite.

@ilovepi ilovepi merged commit 385b07b into main Apr 23, 2025
11 checks passed
@ilovepi ilovepi deleted the users/ilovepi/else-after-ret branch April 23, 2025 17:40
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants