Skip to content

[mlir] Use llvm::SmallVector::pop_back_val() (NFC) #136452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2025
Merged

[mlir] Use llvm::SmallVector::pop_back_val() (NFC) #136452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions mlir/lib/Analysis/Liveness.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,8 +198,7 @@ Liveness::OperationListT Liveness::resolveLiveness(Value value) const {

while (!toProcess.empty()) {
// Get block and block liveness information.
Block *block = toProcess.back();
toProcess.pop_back();
Block *block = toProcess.pop_back_val();
const LivenessBlockInfo *blockInfo = getLiveness(block);

// Note that start and end will be in the same block.
Expand Down
3 changes: 1 addition & 2 deletions mlir/lib/Rewrite/ByteCode.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1198,8 +1198,7 @@ class ByteCodeExecutor {
/// Pops a code iterator from the stack, returning true on success.
void popCodeIt() {
assert(!resumeCodeIt.empty() && "attempt to pop code off empty stack");
curCodeIt = resumeCodeIt.back();
resumeCodeIt.pop_back();
curCodeIt = resumeCodeIt.pop_back_val();
}

/// Return the bytecode iterator at the start of the current op code.
Expand Down
Loading