[compiler-rt][profile][tests][NFC] Avoid using a.out from PATH #136465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix use of `a.out` from the PATH by specifying `./a.out`.
Member
|
@llvm/pr-subscribers-pgo Author: Hubert Tong (hubert-reinterpretcast) ChangesFix use of Full diff: https://github.com/llvm/llvm-project/pull/136465.diff 1 Files Affected:
diff --git a/compiler-rt/test/profile/AIX/pgo-lto-bcdtor-function-section.test b/compiler-rt/test/profile/AIX/pgo-lto-bcdtor-function-section.test
index 36170716b56c2..cc351ef4e0acd 100755
--- a/compiler-rt/test/profile/AIX/pgo-lto-bcdtor-function-section.test
+++ b/compiler-rt/test/profile/AIX/pgo-lto-bcdtor-function-section.test
@@ -15,22 +15,22 @@ int main() { return foo() - 3; }
// RUN: %clang_pgogen -O2 -c -fno-function-sections main.c
//
// RUN: %clang_pgogen -Wl,-bcdtors:all foo.o main.o
-// RUN: rm -f default* && %run a.out
+// RUN: rm -f default* && %run ./a.out
// RUN: llvm-profdata show --all-functions default* | FileCheck %s -check-prefix=BOTH
//
// RUN: %clang_pgogen -Wl,-bcdtors:mbr foo.o main.o
-// RUN: rm -f default* && %run a.out
+// RUN: rm -f default* && %run ./a.out
// RUN: llvm-profdata show --all-functions default* | FileCheck %s -check-prefix=BOTH
// RUN: %clang_pgogen -O2 -c -ffunction-sections foo.c
// RUN: %clang_pgogen -O2 -c -ffunction-sections main.c
//
// RUN: %clang_pgogen -Wl,-bcdtors:all foo.o main.o
-// RUN: rm -f default* && %run a.out
+// RUN: rm -f default* && %run ./a.out
// RUN: llvm-profdata show --all-functions default* | FileCheck %s -check-prefix=BOTH
//
// RUN: %clang_pgogen -Wl,-bcdtors:mbr foo.o main.o
-// RUN: rm -f default* && %run a.out
+// RUN: rm -f default* && %run ./a.out
// RUN: llvm-profdata show --all-functions default* | FileCheck %s -check-prefix=BOTH
// ## no PGO at compile step, but PGO at link step.
@@ -38,11 +38,11 @@ int main() { return foo() - 3; }
// RUN: %clang -O2 -c main.c
//
// RUN: %clang_pgogen -Wl,-bcdtors:all foo.o main.o
-// RUN: rm -f default* && %run a.out
+// RUN: rm -f default* && %run ./a.out
// RUN: llvm-profdata show --all-functions default* | FileCheck %s -check-prefix=NONE
//
// RUN: %clang_pgogen -Wl,-bcdtors:mbr foo.o main.o
-// RUN: rm -f default* && %run a.out
+// RUN: rm -f default* && %run ./a.out
// RUN: llvm-profdata show --all-functions default* | FileCheck %s -check-prefix=NONE
// # LTO, with and without function-sections, and all permutations of -bcdtors
@@ -51,44 +51,44 @@ int main() { return foo() - 3; }
// RUN: %clang -O2 -c -flto main.c
//
// RUN: %clang_pgogen -flto -fno-function-sections -Wl,-bcdtors:all foo.o main.o
-// RUN: rm -f default* && %run a.out
+// RUN: rm -f default* && %run ./a.out
// RUN: llvm-profdata show --all-functions default* | FileCheck %s -check-prefix=NONE
//
// RUN: %clang_pgogen -flto -fno-function-sections -Wl,-bcdtors:mbr foo.o main.o
-// RUN: rm -f default* && %run a.out
+// RUN: rm -f default* && %run ./a.out
// RUN: llvm-profdata show --all-functions default* | FileCheck %s -check-prefix=NONE
//
// RUN: %clang_pgogen -flto -ffunction-sections -Wl,-bcdtors:all foo.o main.o
-// RUN: rm -f default* && %run a.out
+// RUN: rm -f default* && %run ./a.out
// RUN: llvm-profdata show --all-functions default* | FileCheck %s -check-prefix=NONE
//
// RUN: %clang_pgogen -flto -ffunction-sections -Wl,-bcdtors:mbr foo.o main.o
-// RUN: rm -f default* && %run a.out
+// RUN: rm -f default* && %run ./a.out
// RUN: llvm-profdata show --all-functions default* | FileCheck %s -check-prefix=NONE
// ## LTO one file, PGO at compile and link
// RUN: %clang -O2 -c -fno-function-sections foo.c
// RUN: %clang_pgogen -O2 -c -flto main.c
// RUN: %clang_pgogen -flto -fno-function-sections -Wl,-bcdtors:all foo.o main.o
-// RUN: rm -f default* && %run a.out
+// RUN: rm -f default* && %run ./a.out
// RUN: llvm-profdata show --all-functions default* | FileCheck %s -check-prefix=MAIN
// RUN: %clang -O2 -c -flto foo.c
// RUN: %clang_pgogen -O2 -c -fno-function-sections main.c
// RUN: %clang_pgogen -flto -fno-function-sections -Wl,-bcdtors:mbr foo.o main.o
-// RUN: rm -f default* && %run a.out
+// RUN: rm -f default* && %run ./a.out
// RUN: llvm-profdata show --all-functions default* | FileCheck %s -check-prefix=MAIN
// RUN: %clang -O2 -c -flto foo.c
// RUN: %clang_pgogen -O2 -c -ffunction-sections main.c
// RUN: %clang_pgogen -flto -ffunction-sections -Wl,-bcdtors:all foo.o main.o
-// RUN: rm -f default* && %run a.out
+// RUN: rm -f default* && %run ./a.out
// RUN: llvm-profdata show --all-functions default* | FileCheck %s -check-prefix=MAIN
// RUN: %clang -O2 -c -ffunction-sections foo.c
// RUN: %clang_pgogen -O2 -c -flto main.c
// RUN: %clang_pgogen -flto -ffunction-sections -Wl,-bcdtors:mbr foo.o main.o
-// RUN: rm -f default* && %run a.out
+// RUN: rm -f default* && %run ./a.out
// RUN: llvm-profdata show --all-functions default* | FileCheck %s -check-prefix=MAIN
// ## LTO and PGO both files
@@ -96,19 +96,19 @@ int main() { return foo() - 3; }
// RUN: %clang_pgogen -O2 -c -flto main.c
//
// RUN: %clang_pgogen -flto -fno-function-sections -Wl,-bcdtors:all foo.o main.o
-// RUN: rm -f default* && %run a.out
+// RUN: rm -f default* && %run ./a.out
// RUN: llvm-profdata show --all-functions default* | FileCheck %s -check-prefix=BOTH
//
// RUN: %clang_pgogen -flto -fno-function-sections -Wl,-bcdtors:mbr foo.o main.o
-// RUN: rm -f default* && %run a.out
+// RUN: rm -f default* && %run ./a.out
// RUN: llvm-profdata show --all-functions default* | FileCheck %s -check-prefix=BOTH
//
// RUN: %clang_pgogen -flto -ffunction-sections -Wl,-bcdtors:all foo.o main.o
-// RUN: rm -f default* && %run a.out
+// RUN: rm -f default* && %run ./a.out
// RUN: llvm-profdata show --all-functions default* | FileCheck %s -check-prefix=BOTH
//
// RUN: %clang_pgogen -flto -ffunction-sections -Wl,-bcdtors:mbr foo.o main.o
-// RUN: rm -f default* && %run a.out
+// RUN: rm -f default* && %run ./a.out
// RUN: llvm-profdata show --all-functions default* | FileCheck %s -check-prefix=BOTH
// BOTH-DAG: foo:
|
petrhosek
approved these changes
Apr 20, 2025
hubert-reinterpretcast
deleted the
users/hubert-reinterpretcast/nfc-test-fix-a.out-PATH-issue
branch
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
…136465) Fix use of `a.out` from the PATH by specifying `./a.out`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix use of
a.outfrom the PATH by specifying./a.out.