Skip to content

[IRCE] Fix '"Instruction does not dominate all uses!" after IRCE pass #63984' #136505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[IRCE] Fix '"Instruction does not dominate all uses!" after IRCE pass #63984' #136505

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
785d00e
IRCE: Fix '"Instruction does not dominate all uses!" after IRCE pass …
Zentrik Apr 20, 2025
b167a5a
Add test following `llvm-project/llvm/test/Transforms/IRCE/pr89959.ll`
Zentrik Apr 21, 2025
4609f37
Simplify code
Zentrik Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions llvm/lib/Transforms/Scalar/InductiveRangeCheckElimination.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,8 +265,13 @@ bool InductiveRangeCheck::parseRangeCheckICmp(Loop *L, ICmpInst *ICI,
ScalarEvolution &SE,
const SCEVAddRecExpr *&Index,
const SCEV *&End) {
auto IsLoopInvariant = [&SE, L](Value *V) {
return SE.isLoopInvariant(SE.getSCEV(V), L);
auto IsLoopInvariantAndNotUndef = [&SE, L](Value *V) {
const SCEV *S = SE.getSCEV(V);

if (isa<SCEVCouldNotCompute>(S))
return false;

return SE.isLoopInvariant(SE.getSCEV(V), L) && !SE.containsUndefs(S);
};

ICmpInst::Predicate Pred = ICI->getPredicate();
Expand All @@ -277,10 +282,10 @@ bool InductiveRangeCheck::parseRangeCheckICmp(Loop *L, ICmpInst *ICI,
return false;

// Canonicalize to the `Index Pred Invariant` comparison
if (IsLoopInvariant(LHS)) {
if (IsLoopInvariantAndNotUndef(LHS)) {
std::swap(LHS, RHS);
Pred = CmpInst::getSwappedPredicate(Pred);
} else if (!IsLoopInvariant(RHS))
} else if (!IsLoopInvariantAndNotUndef(RHS))
// Both LHS and RHS are loop variant
return false;

Expand Down
Loading