Skip to content

[clang-format] Don't test stability if JS format test fails #136662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025
Merged

[clang-format] Don't test stability if JS format test fails #136662

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions clang/unittests/Format/FormatTestJS.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,18 +48,22 @@ class FormatTestJS : public testing::Test {
static void verifyFormat(
StringRef Code,
const FormatStyle &Style = getGoogleStyle(FormatStyle::LK_JavaScript)) {
EXPECT_EQ(Code.str(), format(Code, Style)) << "Expected code is not stable";
std::string Result = format(test::messUp(Code), Style);
EXPECT_EQ(Code.str(), Result) << "Formatted:\n" << Result;
auto Result = format(test::messUp(Code), Style);
EXPECT_EQ(Code, Result) << "Formatted:\n" << Result;
if (Code != Result)
return;
EXPECT_EQ(Code, format(Code, Style)) << "Expected code is not stable";
}

static void verifyFormat(
StringRef Expected, StringRef Code,
const FormatStyle &Style = getGoogleStyle(FormatStyle::LK_JavaScript)) {
EXPECT_EQ(Expected.str(), format(Expected, Style))
auto Result = format(Code, Style);
EXPECT_EQ(Expected, Result) << "Formatted:\n" << Result;
if (Expected != Result)
return;
EXPECT_EQ(Expected, format(Expected, Style))
<< "Expected code is not stable";
std::string Result = format(Code, Style);
EXPECT_EQ(Expected.str(), Result) << "Formatted:\n" << Result;
}
};

Expand Down
Loading