-
Notifications
You must be signed in to change notification settings - Fork 15.3k
[RISCV] Add fixed-length patterns for disjoint or patterns for vwadd[u].v{v,x} #136824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -497,6 +497,16 @@ let HasOneUse = 1 in { | |||||||||||||
| node:$E), | ||||||||||||||
| (riscv_add_vl node:$A, node:$B, node:$C, | ||||||||||||||
| node:$D, node:$E)>; | ||||||||||||||
| def riscv_or_vl_is_add_oneuse : PatFrag<(ops node:$A, node:$B, node:$C, node:$D, | ||||||||||||||
| node:$E), | ||||||||||||||
| (riscv_or_vl node:$A, node:$B, node:$C, | ||||||||||||||
| node:$D, node:$E), [{ | ||||||||||||||
| if (N->getFlags().hasDisjoint()) | ||||||||||||||
| return true; | ||||||||||||||
| KnownBits Known0 = CurDAG->computeKnownBits(N->getOperand(0), 0); | ||||||||||||||
| KnownBits Known1 = CurDAG->computeKnownBits(N->getOperand(1), 0); | ||||||||||||||
| return KnownBits::haveNoCommonBitsSet(Known0, Known1); | ||||||||||||||
| }]>; | ||||||||||||||
| def riscv_sub_vl_oneuse : PatFrag<(ops node:$A, node:$B, node:$C, node:$D, | ||||||||||||||
| node:$E), | ||||||||||||||
| (riscv_sub_vl node:$A, node:$B, node:$C, | ||||||||||||||
|
|
@@ -2016,6 +2026,37 @@ foreach vtiToWti = AllWidenableIntVectors in { | |||||||||||||
| } | ||||||||||||||
| } | ||||||||||||||
|
|
||||||||||||||
| // DAGCombiner::hoistLogicOpWithSameOpcodeHands may hoist disjoint ors | ||||||||||||||
| // to (ext (or disjoint (a, b))) | ||||||||||||||
| multiclass VPatWidenOrDisjointVL_VV_VX<SDNode extop, string instruction_name> { | ||||||||||||||
| foreach vtiToWti = AllWidenableIntVectors in { | ||||||||||||||
| defvar vti = vtiToWti.Vti; | ||||||||||||||
| defvar wti = vtiToWti.Wti; | ||||||||||||||
| let Predicates = !listconcat(GetVTypePredicates<vti>.Predicates, | ||||||||||||||
| GetVTypePredicates<wti>.Predicates) in { | ||||||||||||||
| def : Pat<(wti.Vector (extop (vti.Vector | ||||||||||||||
| (riscv_or_vl_is_add_oneuse | ||||||||||||||
| vti.RegClass:$rs2, vti.RegClass:$rs1, | ||||||||||||||
| undef, srcvalue, srcvalue)), | ||||||||||||||
| VMV0:$vm, VLOpFrag)), | ||||||||||||||
| (!cast<Instruction>(instruction_name#"_VV_"#vti.LMul.MX#"_MASK") | ||||||||||||||
| (wti.Vector (IMPLICIT_DEF)), vti.RegClass:$rs2, | ||||||||||||||
| vti.RegClass:$rs1, VMV0:$vm, GPR:$vl, vti.Log2SEW, TA_MA)>; | ||||||||||||||
|
||||||||||||||
| (!cast<Instruction>(instruction_name#"_VV_"#vti.LMul.MX#"_MASK") | |
| (wti.Vector (IMPLICIT_DEF)), vti.RegClass:$rs2, | |
| vti.RegClass:$rs1, VMV0:$vm, GPR:$vl, vti.Log2SEW, TA_MA)>; | |
| (!cast<Instruction>(instruction_name#"_VV_"#vti.LMul.MX#"_MASK") | |
| (wti.Vector (IMPLICIT_DEF)), vti.RegClass:$rs2, | |
| vti.RegClass:$rs1, VMV0:$vm, GPR:$vl, vti.Log2SEW, TA_MA)>; |
Outdated
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| (riscv_or_vl_is_add_oneuse | |
| vti.RegClass:$rs2, (SplatPat (XLenVT GPR:$rs1)), | |
| undef, srcvalue, srcvalue)), | |
| (riscv_or_vl_is_add_oneuse | |
| vti.RegClass:$rs2, (SplatPat (XLenVT GPR:$rs1)), | |
| undef, srcvalue, srcvalue)), |
Outdated
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| (!cast<Instruction>(instruction_name#"_VX_"#vti.LMul.MX#"_MASK") | |
| (wti.Vector (IMPLICIT_DEF)), vti.RegClass:$rs2, | |
| GPR:$rs1, VMV0:$vm, GPR:$vl, vti.Log2SEW, TA_MA)>; | |
| (!cast<Instruction>(instruction_name#"_VX_"#vti.LMul.MX#"_MASK") | |
| (wti.Vector (IMPLICIT_DEF)), vti.RegClass:$rs2, | |
| GPR:$rs1, VMV0:$vm, GPR:$vl, vti.Log2SEW, TA_MA)>; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.