Skip to content

Conversation

clementval
Copy link
Contributor

Name was changed in #135478

@clementval clementval requested a review from wangzpgi April 23, 2025 18:16
@llvmbot llvmbot added flang Flang issues not falling into any other category flang:fir-hlfir labels Apr 23, 2025
@llvmbot
Copy link
Member

llvmbot commented Apr 23, 2025

@llvm/pr-subscribers-flang-fir-hlfir

Author: Valentin Clement (バレンタイン クレメン) (clementval)

Changes

Name was changed in #135478


Full diff: https://github.com/llvm/llvm-project/pull/137034.diff

1 Files Affected:

  • (modified) flang/lib/Optimizer/Dialect/CUF/CUFToLLVMIRTranslation.cpp (+1-1)
diff --git a/flang/lib/Optimizer/Dialect/CUF/CUFToLLVMIRTranslation.cpp b/flang/lib/Optimizer/Dialect/CUF/CUFToLLVMIRTranslation.cpp
index 7ed7f35595968..5c4e4179d2dee 100644
--- a/flang/lib/Optimizer/Dialect/CUF/CUFToLLVMIRTranslation.cpp
+++ b/flang/lib/Optimizer/Dialect/CUF/CUFToLLVMIRTranslation.cpp
@@ -28,7 +28,7 @@ LogicalResult registerModule(cuf::RegisterModuleOp op,
                              llvm::IRBuilderBase &builder,
                              LLVM::ModuleTranslation &moduleTranslation) {
   std::string binaryIdentifier =
-      op.getName().getLeafReference().str() + "_bin_cst";
+      op.getName().getLeafReference().str() + "_binary";
   llvm::Module *module = moduleTranslation.getLLVMModule();
   llvm::Value *binary = module->getGlobalVariable(binaryIdentifier, true);
   if (!binary)

@clementval clementval merged commit 0fdb908 into llvm:main Apr 23, 2025
12 of 13 checks passed
@clementval clementval deleted the cuf_binary branch April 23, 2025 20:34
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

flang:fir-hlfir flang Flang issues not falling into any other category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants