[compiler-rt] Only include asan on x86 architectures on Windows #137173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids building asan when targeting Windows on armv7 or aarch64. It is possible to build asan successfully for those configurations (since 5ea9dd8 and 0c39113), but asan isn't functional there. This change skips building asan for targets other than x86_32 and x86_64. By excluding asan from the build, we fix the "check-ubsan" target for armv7 and aarch64 Windows. If asan is included in the build, an ubsan-asan configuration gets added to the tests, and as asan isn't functional for these targets, it produces a lot of test failures even when just trying to run "check-ubsan".
Member
Author
vitalybuka
approved these changes
Apr 24, 2025
DoDoENT
approved these changes
Apr 24, 2025
Contributor
DoDoENT
left a comment
DoDoENT
left a comment
There was a problem hiding this comment.
It looks good to me, too. My commit just made it compile on ARM Windows, but it never worked correctly, so it absolutely makes sense to disable it altogether on ARM Windows.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
…#137173) This avoids building asan when targeting Windows on armv7 or aarch64. It is possible to build asan successfully for those configurations (since 5ea9dd8 and 0c39113), but asan isn't functional there. This change skips building asan for targets other than x86_32 and x86_64. By excluding asan from the build, we fix the "check-ubsan" target for armv7 and aarch64 Windows. If asan is included in the build, an ubsan-asan configuration gets added to the tests, and as asan isn't functional for these targets, it produces a lot of test failures even when just trying to run "check-ubsan".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids building asan when targeting Windows on armv7 or aarch64. It is possible to build asan successfully for those configurations (since 5ea9dd8 and 0c39113), but asan isn't functional there.
This change skips building asan for targets other than x86_32 and x86_64.
By excluding asan from the build, we fix the "check-ubsan" target for armv7 and aarch64 Windows. If asan is included in the build, an ubsan-asan configuration gets added to the tests, and as asan isn't functional for these targets, it produces a lot of test failures even when just trying to run "check-ubsan".