[lldb-dap] Fix formatting chrono::seconds warning.

[ashgti]

Updated the format to use llvm::formatv instead of printf style format.

[llvmbot]

@llvm/pr-subscribers-lldb

Author: John Harrison (ashgti)

Changes

Updated the format to use llvm::formatv instead of printf style format.

---

Full diff: https://github.com/llvm/llvm-project/pull/137371.diff

1 Files Affected:

• (modified) lldb/tools/lldb-dap/DAP.cpp (+5-2)

diff --git a/lldb/tools/lldb-dap/DAP.cpp b/lldb/tools/lldb-dap/DAP.cpp
index 185b475cfcad6..c21dbbdc6e8ab 100644
--- a/lldb/tools/lldb-dap/DAP.cpp
+++ b/lldb/tools/lldb-dap/DAP.cpp
@@ -35,6 +35,7 @@
 #include "llvm/ADT/StringExtras.h"
 #include "llvm/ADT/StringRef.h"
 #include "llvm/ADT/Twine.h"
+#include "llvm/Support/Chrono.h"
 #include "llvm/Support/Error.h"
 #include "llvm/Support/ErrorHandling.h"
 #include "llvm/Support/FormatVariadic.h"
@@ -968,8 +969,10 @@ lldb::SBError DAP::WaitForProcessToStop(std::chrono::seconds seconds) {
     }
     std::this_thread::sleep_for(std::chrono::microseconds(250));
   }
-  error.SetErrorStringWithFormat("process failed to stop within %lld seconds",
-                                 seconds.count());
+  error.SetErrorString(
+      llvm::formatv("process failed to stop within {0}", seconds)
+          .str()
+          .c_str());
   return error;
 }
 

[ashgti]

Looks like c4b7bd9 already fixed this with a static cast.

[JDevlieghere]

FWIW I (also) prefer the formatv approach.

[DavidSpickett]

👍