[llvm] Fixed ItaniumDemangle.h compiled by MSVC #137409
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the includes tree is big enough, `llvm::itanium_demangle::PointerType` may conflict with `llvm::PointerType` from other headers. This patch fixes the following [error](https://lab.llvm.org/buildbot/#/builders/141/builds/8206): ``` C:\lldb-aarch64-windows\llvm-project\llvm\include\llvm/Demangle/ItaniumDemangle.h(617,16): warning: unqualified friend declaration referring to type outside of the nearest enclosing namespace is a Microsoft extension; add a nested name specifier [-Wmicrosoft-unqualified-friend] 617 | friend class PointerType; | ^ | ::llvm:: C:\lldb-aarch64-windows\llvm-project\llvm\include\llvm/Demangle/ItaniumDemangle.h(667,24): error: 'Protocol' is a private member of 'llvm::itanium_demangle::ObjCProtoName' 667 | OB += objcProto->Protocol; | ^ C:\lldb-aarch64-windows\llvm-project\llvm\include\llvm/Demangle/ItaniumDemangle.h(615,20): note: implicitly declared private here 615 | std::string_view Protocol; ```
Member
|
@llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) ChangesIf the includes tree is big enough, Few buildbots broken by #131836 must be green after this patch. Full diff: https://github.com/llvm/llvm-project/pull/137409.diff 1 Files Affected:
diff --git a/llvm/include/llvm/Demangle/ItaniumDemangle.h b/llvm/include/llvm/Demangle/ItaniumDemangle.h
index b4a4c72021fd1..f37905971a833 100644
--- a/llvm/include/llvm/Demangle/ItaniumDemangle.h
+++ b/llvm/include/llvm/Demangle/ItaniumDemangle.h
@@ -610,6 +610,8 @@ class EnableIfAttr : public Node {
}
};
+class PointerType;
+
class ObjCProtoName : public Node {
const Node *Ty;
std::string_view Protocol;
|
Member
|
Should have been fixed in this commit: bd96fa7 The bots are now red for other reasons |
Member
|
Apologies for the disruption with the buildbots |
Contributor
Author
|
Closed in favor of bd96fa7 |
Contributor
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the includes tree is big enough,
llvm::itanium_demangle::PointerTypemay conflict withllvm::PointerTypefrom other headers. This patch fixes the following error:Few buildbots broken by #131836 must be green after this patch.