[lldb-dap] Make lldb-dap.executable-path machine specific

[JDevlieghere]

Change the scope [1] of lldb-dap.executable-path to "machine-overridable":

Machine specific settings that can be overridden by workspace or
folder settings.

Practically speaking, this means that the path won't be synced across machines and "(Not synced)" will show up next to the setting. I believe it doesn't make sense to sync this setting (and I remember a bug report where this caused trouble when using VS Code remotely), plus it matches what clangd does for its corresponding setting. The extension has logic to find the binary in your path or with xcrun which in most cases should do the right thing and prevent you from having to override this setting.

[1] https://code.visualstudio.com/api/references/contribution-points#Configuration-property-schema

[JDevlieghere]

Here's what this looks like in the UI:

[llvmbot]

@llvm/pr-subscribers-lldb

Author: Jonas Devlieghere (JDevlieghere)

Changes

Change the scope [1] of lldb-dap.executable-path to "machine-overridable":

> Machine specific settings that can be overridden by workspace or
> folder settings.

Practically speaking, this means that the path won't be synced across machines and "(Not synced)" will show up next to the setting. I believe it doesn't make sense to sync this setting (and I remember a bug report where this caused trouble when using VS Code remotely), plus it matches what clangd does for its corresponding setting.

[1] https://code.visualstudio.com/api/references/contribution-points#Configuration-property-schema

---

Full diff: https://github.com/llvm/llvm-project/pull/137485.diff

1 Files Affected:

• (modified) lldb/tools/lldb-dap/package.json (+2-1)

diff --git a/lldb/tools/lldb-dap/package.json b/lldb/tools/lldb-dap/package.json
index 3957e3f27f297..c25d5033d09f1 100644
--- a/lldb/tools/lldb-dap/package.json
+++ b/lldb/tools/lldb-dap/package.json
@@ -74,7 +74,8 @@
         "lldb-dap.executable-path": {
           "scope": "resource",
           "type": "string",
-          "description": "The path to the lldb-dap binary."
+          "scope": "machine-overridable",
+          "description": "The path to the lldb-dap binary, e.g. /usr/local/bin/lldb-dap"
         },
         "lldb-dap.arguments": {
           "scope": "resource",