Skip to content

[IR] Simplify isRequired and passIsRequiredImpl (NFC) #137503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kazutakahirata merged 1 commit into from
Apr 27, 2025
Merged

[IR] Simplify isRequired and passIsRequiredImpl (NFC) #137503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions llvm/include/llvm/IR/PassInstrumentation.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,14 +216,9 @@ class PassInstrumentation {
template <typename PassT>
using has_required_t = decltype(std::declval<PassT &>().isRequired());

template <typename PassT>
static std::enable_if_t<is_detected<has_required_t, PassT>::value, bool>
isRequired(const PassT &Pass) {
return Pass.isRequired();
}
template <typename PassT>
static std::enable_if_t<!is_detected<has_required_t, PassT>::value, bool>
isRequired(const PassT &Pass) {
template <typename PassT> static bool isRequired(const PassT &Pass) {
if constexpr (is_detected<has_required_t, PassT>::value)
return Pass.isRequired();
return false;
}

Expand Down
11 changes: 3 additions & 8 deletions llvm/include/llvm/IR/PassManagerInternal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,14 +102,9 @@ struct PassModel : PassConcept<IRUnitT, AnalysisManagerT, ExtraArgTs...> {
template <typename T>
using has_required_t = decltype(std::declval<T &>().isRequired());

template <typename T>
static std::enable_if_t<is_detected<has_required_t, T>::value, bool>
passIsRequiredImpl() {
return T::isRequired();
}
template <typename T>
static std::enable_if_t<!is_detected<has_required_t, T>::value, bool>
passIsRequiredImpl() {
template <typename T> static bool passIsRequiredImpl() {
if constexpr (is_detected<has_required_t, T>::value)
return T::isRequired();
return false;
}

Expand Down