Skip to content

[mlir] Simplify PreservedAnalyses::isInvalidated (NFC) #137506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kazutakahirata merged 1 commit into from
Apr 27, 2025
Merged

[mlir] Simplify PreservedAnalyses::isInvalidated (NFC) #137506

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions mlir/include/mlir/Pass/AnalysisManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,17 +85,14 @@ template <typename T, typename... Args>
using has_is_invalidated = decltype(std::declval<T &>().isInvalidated(
std::declval<const PreservedAnalyses &>()));

/// Implementation of 'isInvalidated' if the analysis provides a definition.
template <typename AnalysisT>
std::enable_if_t<llvm::is_detected<has_is_invalidated, AnalysisT>::value, bool>
isInvalidated(AnalysisT &analysis, const PreservedAnalyses &pa) {
return analysis.isInvalidated(pa);
}
/// Default implementation of 'isInvalidated'.
template <typename AnalysisT>
std::enable_if_t<!llvm::is_detected<has_is_invalidated, AnalysisT>::value, bool>
isInvalidated(AnalysisT &analysis, const PreservedAnalyses &pa) {
return !pa.isPreserved<AnalysisT>();
bool isInvalidated(AnalysisT &analysis, const PreservedAnalyses &pa) {
if constexpr (llvm::is_detected<has_is_invalidated, AnalysisT>::value)
/// Implementation of 'isInvalidated' if the analysis provides a definition.
return analysis.isInvalidated(pa);
else
/// Default implementation of 'isInvalidated'.
return !pa.isPreserved<AnalysisT>();
}
} // namespace analysis_impl

Expand Down