Skip to content

[Support] Simplify setDefaultImpl (NFC) #137528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 27, 2025
Merged

[Support] Simplify setDefaultImpl (NFC) #137528

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea2d0be
[Support] Simplify setDefaultImpl (NFC)
kazutakahirata Apr 27, 2025
3d437a2
Address a comment.
kazutakahirata Apr 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions llvm/include/llvm/Support/CommandLine.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1459,20 +1459,16 @@ class opt
}
}

template <class T, class = std::enable_if_t<std::is_assignable_v<T &, T>>>
void setDefaultImpl() {
const OptionValue<DataType> &V = this->getDefault();
if (V.hasValue())
this->setValue(V.getValue());
else
this->setValue(T());
void setDefault() override {
if constexpr (std::is_assignable_v<DataType &, DataType>) {
const OptionValue<DataType> &V = this->getDefault();
if (V.hasValue())
this->setValue(V.getValue());
else
this->setValue(DataType());
}
}

template <class T, class = std::enable_if_t<!std::is_assignable_v<T &, T>>>
void setDefaultImpl(...) {}

void setDefault() override { setDefaultImpl<DataType>(); }

void done() {
addArgument();
Parser.initialize();
Expand Down
Loading