Skip to content

[TableGen] Simplify insertBits (NFC) #137538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2025
Merged

[TableGen] Simplify insertBits (NFC) #137538

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions llvm/utils/TableGen/DecoderEmitter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2145,16 +2145,14 @@ static void emitInsertBits(formatted_raw_ostream &OS) {
// Helper function for inserting bits extracted from an encoded instruction into
// a field.
template <typename InsnType>
static std::enable_if_t<std::is_integral<InsnType>::value>
insertBits(InsnType &field, InsnType bits, unsigned startBit, unsigned numBits) {
assert(startBit + numBits <= sizeof field * 8);
field |= (InsnType)bits << startBit;
}

template <typename InsnType>
static std::enable_if_t<!std::is_integral<InsnType>::value>
insertBits(InsnType &field, uint64_t bits, unsigned startBit, unsigned numBits) {
field.insertBits(bits, startBit, numBits);
static void insertBits(InsnType &field, InsnType bits, unsigned startBit,
unsigned numBits) {
if constexpr (std::is_integral<InsnType>::value) {
assert(startBit + numBits <= sizeof field * 8);
field |= (InsnType)bits << startBit;
} else {
field.insertBits(bits, startBit, numBits);
}
}
)";
}
Expand Down