[CodeGen] Use OwningArrayRef in NodeMetadata (NFC) #137539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NodeMetadata::optUnsafeEdges returns ArrayRef, packaging OptUnsafeEdges and NumOpts. This in turn allows use of llvm::copy and llvm::is_contained elsewhere in the class.
nikic
reviewed
Apr 27, 2025
Contributor
nikic
left a comment
nikic
left a comment
There was a problem hiding this comment.
Can we replace the member with OwningArrayRef instead?
kuhar
approved these changes
Apr 27, 2025
Contributor
Author
I don't think so. The array could be reallocated in the middle of lifetime: |
Contributor
OwningArrayRef has operator= so I think that should be ok? |
kazutakahirata
changed the title
Contributor
Author
You are right. I now use |
kazutakahirata
changed the title
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/169/builds/10904 Here is the relevant piece of the build log for the reference |
Collaborator
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/94/builds/6611 Here is the relevant piece of the build log for the reference |
Member
|
Can you check if the PR breaks the following buildbot |
Contributor
|
From the buildbot log: |
fmayer
added a commit
that referenced
this pull request
Apr 28, 2025
Reverts #137539 This breaks the MSan buildbot. Please either fix the build or merge this revert.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
) Reverts llvm#137539 This breaks the MSan buildbot. Please either fix the build or merge this revert.
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
May 6, 2025
…" (#137684) Reverts llvm/llvm-project#137539 This breaks the MSan buildbot. Please either fix the build or merge this revert.
GeorgeARM
pushed a commit
to GeorgeARM/llvm-project
that referenced
this pull request
May 7, 2025
) Reverts llvm#137539 This breaks the MSan buildbot. Please either fix the build or merge this revert.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.