Skip to content

[clang][bytecode] Check live-ness when calling dtors #137645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025
Merged

[clang][bytecode] Check live-ness when calling dtors #137645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions clang/lib/AST/ByteCode/Interp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1375,6 +1375,9 @@ static bool checkConstructor(InterpState &S, CodePtr OpPC, const Function *Func,
}

bool CheckDestructor(InterpState &S, CodePtr OpPC, const Pointer &Ptr) {
if (!CheckLive(S, OpPC, Ptr, AK_Destroy))
return false;

// Can't call a dtor on a global variable.
if (Ptr.block()->isStatic()) {
const SourceInfo &E = S.Current->getSource(OpPC);
Expand Down
11 changes: 11 additions & 0 deletions clang/test/AST/ByteCode/records.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1819,3 +1819,14 @@ namespace GlobalDtor {
a.~A(); // both-note {{cannot modify an object that is visible outside}}
}
}

namespace NullDtor {
struct S {};
constexpr int foo() { // both-error {{never produces a constant expression}}
S *s = nullptr;
s->~S(); // both-note 2{{destruction of dereferenced null pointer is not allowed in a constant expression}}
return 10;
}
static_assert(foo() == 10, ""); // both-error {{not an integral constant expression}} \
// both-note {{in call to}}
}